Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rapidjson #272

Merged
merged 3 commits into from Jan 9, 2024
Merged

Conversation

hendrikmuhs
Copy link
Contributor

update the rapidjson subtree

6089180e Use correct format for printf
f9d53419 Add Hasher tests for objects where key eq value
6f79698b Fix swapped high and low offset basis values
eee82cb0 Fix object hashing in schema
b4a6da3e unit tests for 'Stringify NaN, Inf as null'
e7b6e5a2 Fix: 'Stringify NaN, Inf as null'
476ffa2f Rename to fix allocator shadowing
5e17dbed Eliminate old style cast warning
956063db Fixing printf format warning
30f54566 Merge pull request #1901 from JackBoosY/master
516d0473 Remove empty cross-reference in comment
52dd9470 Merge branch 'master' into pr/1901
a95e013b Stringify NaN, Inf as null if needs
973dc9c0 Avoid ptrdiff between pointers to different allocations
2a1f586b Check for __GNUC__ definition
0e88d5e4 Eliminate missing prototypes warning
949c771b Resolve conflict with Windows header about max macro
083f359f CMakeLists: fix optflags for ppc
012be852 Use passed in allocator.
1ce516e5 Suppress uritest
778dc8b0 fix #1
76281ff3 fix a typo in error.h: literial -> literal
a98e9999 do not define operator!= in C++20
b08672d4 review comment updates
55eca66f code & tests for openapi 2.0 & 3.0 suppprt
80b6d1c8 small corrections for schema.h
97fd8301 attempt to fix SEH
7cad78e2 tidy up after merge from master
794248ee fix build break
2d87923e remove unnecessary templating from schema tests
aa1f2225 correct address.json so tests pass
ecb8d9e3 add dump of unexpected schema errors in schematest.cpp
89f6717f corrections
338d8def initial
06d58b9e Update dtoa.h
22a62fcc Update allocators.h
27c3a8dc docs: fix simple typo, perecent -> percent
232389d4 delete unused variable
64faab2e gate definition of symmetric equality operators on impl, not lib
719304b1 fixes for natvis
dd3f730d Make schema dtor robust against exceptions
781a4e66 Try to fix MSVC build.
88f8ddd7 Include conceptual change from PR 2001.
46959535 Avoid exit-time destructors.
0390b1ad Avoid exit-time destructors.
2b2c8045 encdedstreamtest: fix use-after-free compile error with gcc-12
1f59c69c valuetest: fix potential write of terminating nul past the end of the destination
3445e155 Merge branch 'master' into master
fcb23c2d Merge pull request #2008 from agate-pris/access-to-allocator-types
bdc49ad8 Merge pull request #2014 from lazydroid/dev/lenik/fix_shadowed_variables
6b500986 fix shadowed variable, take 2
3988c5e2 fix shadowed variable
386d31ab Allow access to the template parameter StackAllocator in the GenericDocument
79d7a448 Allow the macro RAPIDJSON_DEFAULT_STACK_ALLOCATOR to be used in any namespace
9965ab37 Allow the macro RAPIDJSON_DEFAULT_ALLOCATOR to be used in any namespace
8261c1dd Merge pull request #1969 from MalcolmTyrrell/MalcolmTyrrell/sanitizeSchemaCode
0d78b1ce Merge pull request #1989 from adamcalhoon/really-fix-placement-new-alignment
1dff2abf Fix the alignment of placement new buffer for GenericValue.
e4bde977 Merge pull request #1988 from Tencent/revert-1987-fix-placement-new-alignment
88bbd87d Revert "Fix the alignment of placement new buffer for GenericValue."
bf8ca5da Merge pull request #1987 from adamcalhoon/fix-placement-new-alignment
5b242b6b Fix the alignment of placement new buffer for GenericValue.
fd3dc29a Merge pull request #1944 from ilelann/patch-1
53602ec6 Sanitize the code in schema.h
0d4517f1 Merge pull request #1961 from jedwardsol/issue1960_arm64ec_intrinsic
060c348e use softintrin on arm64ec
4d6cb081 Merge pull request #1949 from ardb-uk/master
033bef3c Merge pull request #1 from ardb-uk/ardb-uk-patch-1
befba39a Merge pull request KeyviDev#2 from ardb-uk/ardb-uk-patch-1-1
4bbaf28f Add files via upload
14f1e37f Resolve issue 1948
e6736d1b Support CMake none targets
2e8f5d89 Merge pull request #1940 from smhdfdl/issue-1924
9ea3f45d fix the warning
b9ae2499 Merge pull request #1941 from DiamondI/patch-1
553a3ea3 typo on documentation dom.zh-cn.md: "己于" -> "已于"
864e44ae Merge branch 'master' of https://github.com/Tencent/rapidjson
00dbcf2c Merge pull request #1926 from Kyrega/master
22ee8b07 Correct WIStreamWrapper
a3d52c75 No default template parameter for older compilers
19b55c90 No default template parameter for older compilers
128b1031 Use rapidjson internal::SelectIf
8710d7e9 Do not depend on c++11 conditional
e0512e09 Using unsigned for WIStreamWrapper
7fac34f7 Added typename
b952a592 Fix RawNumber for longer char types
28c59ab4 Merge pull request #1922 from jack-perisich/grisu2_precision
bb062110 Fix small errors in dtoa output for certain doubles
7ee918fc Merge branch 'master' of https://github.com/Tencent/rapidjson
48fbd8cd Merge pull request #1848 from smhdfdl/id-and-ref
8d16abd9 Uri Parse improvements
b557259f Merge pull request #1904 from Tencent/issue1899_pointerappend
a21cf9f7 equiv fix for issue 1899
8c29a7b4 Fix Pointer::Append() crash for custom allocator on Windows
12b88efa fix coverage again
f6ebcb20 fix Uri.Match optional arg
3df804c1 fix coverage, unit test allocators and equality
18ab3b16 remove temp debug statements
6d253c16 remove compiler warning
28bcbd3f make std::string optional
f4be0ada Use modern cmake function export to generate target
494447b7 remove copyright & debug statements
6e58a53f fix coverage
3987d82f Merge branch 'master' of https://github.com/Tencent/rapidjson into id-and-ref
9c1002f9 rge branch 'master' of https://github.com/Tencent/rapidjson
17aa824c Merge pull request #1885 from saurabhchardereal/master
cd737fb5 Improve documentation
25fa7a11 Merge pull request #1883 from nkolotov/fix/issues/1882
3aa8d04b Fixed -Wshadow warning.
bc026e3f satisfy all compilers 3
24b9b7e2 satisfy all compilers 2
32722fa3 satisfy all compilers
8768b5b1 correct #defines in uri.h
6c9da69a remove comma
6b57738e handle internal refs properly
fe1a29ca fix platform-dependent compiler error with >>
ad73c032 fix compile errors
892f6e3f fix bracket
cabc3d5a merge
7698b3cd code and tests
dad85cab Merge pull request KeyviDev#2 from smhdfdl/multiple-validation-failures-and-validation-messages

git-subtree-dir: keyvi/3rdparty/rapidjson
git-subtree-split: 6089180ecb704cb2b136777798fa1be303618975
@hendrikmuhs hendrikmuhs marked this pull request as ready for review January 6, 2024 21:13
@hendrikmuhs
Copy link
Contributor Author

hendrikmuhs commented Jan 8, 2024

It seems that I broke the manylinux on arm docker image. I've pushed a new one. The update I made in #263 actually never made it to docker hub as I assumed that the hub images get recreated automatically. But it turns out that docker images have to be pushed manually. Was that always like this or is it due to changes by license changes by dockerhub? The autosync requires a subscription.

Anyway, the docker image still installs 'snappy-devel', but for some reason cmake does not find 'snappy'. I will create a PR with my latest docker files asap.

@ivanychev @narekgharibyan any ideas?

discussion continues in #273, I might have a fix.

Copy link
Member

@narekgharibyan narekgharibyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Will continue convo about Docker builds in #273

@narekgharibyan
Copy link
Member

But it turns out that docker images have to be pushed manually.

I def remember pushing docker images myself before.

@hendrikmuhs hendrikmuhs merged commit ab77936 into KeyviDev:master Jan 9, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants