Travis docker, CPython 3.7 #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- using default gcov
- added pypy2 builds back
hendrikmuhs
reviewed
Aug 28, 2018
.travis.yml
Outdated
| - BUILD_TYPE=sdist PYTHON_VERSION=27 | ||
| - BUILD_TYPE=doc | ||
| - BUILD_TYPE=rust | ||
| - BUILD_TYPE=linux DOCKER_IMAGE=narekgharibyan/keyvi-ubuntu-builder CONF=release |
There was a problem hiding this comment.
I created a keyvi-ubuntu-builder under keyvidev and added you as collaborator
hendrikmuhs
reviewed
Aug 28, 2018
.travis.yml
Outdated
| - BUILD_TYPE=python DOCKER_IMAGE=narekgharibyan/keyvi-ubuntu-builder PYTHON_VERSION=3.7.0 CONF=release | ||
| - BUILD_TYPE=python DOCKER_IMAGE=narekgharibyan/keyvi-ubuntu-builder PYTHON_VERSION=pypy2.7-6.0.0 CONF=release | ||
|
|
||
| - BUILD_TYPE=python DOCKER_IMAGE=narekgharibyan/keyvi-ubuntu-builder PYTHON_VERSION=2.7.15 CONF=debug |
There was a problem hiding this comment.
is it somehow possible to pick the latest major.minor? 2.7 in this case?
There was a problem hiding this comment.
Seems there is not out of box way of doing that, we will need to implement some script to list available versions and then picking up the latest one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements use of new
keyvi-ubuntu-builderdocker image on Travis-CI.This migration provides following advantages:
cpython3.7andpypy2(added back)