Add translit ipa #31
Merged
Add translit ipa #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 126
💛 - Coveralls |
tarunsingh5
approved these changes
Sep 14, 2018
|
@ManjotS @navdeepsinghkhalsa can we merge & close this out |
|
@navdeepsinghkhalsa I am confident enough in it (it will need adjustments in the future just as english does) can we merge? |
navdeepsinghkhalsa
requested changes
Jan 28, 2019
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "anvaad-js", | |||
| "version": "1.0.9", | |||
There was a problem hiding this comment.
This will be done by npm version when releasing
|
Could you also please resolve conflicts? |
| @@ -3,6 +3,9 @@ const translit = require('../translit'); | |||
| describe('translit', () => { | |||
| it('Should return transliteration of Gurmukhi', () => { | |||
| expect(JSON.stringify(translit('CMqu ] ijau jwnhu iqau rwKu hir pRB qyirAw ] kyqy gnau AsMK Avgx myirAw ] AsMK Avgx Kqy Pyry inqpRiq sd BUlIAY ] moh mgn ibkrwl mwieAw qau pRswdI GUlIAY ] lUk krq ibkwr ibKVy pRB nyr hU qy nyirAw ] ibnvMiq nwnk dieAw Dwrhu kwiF Bvjl PyirAw ]1]', 'all'))) | |||
| .toBe(JSON.stringify({ english: 'chha(n)t || jiau jaanahu tiau raakh har prabh teriaa || kete ganau asa(n)kh avagan meriaa || asa(n)kh avagan khate fere nitaprat sadh bhooleeaai || moh magan bikaraal maiaa tau prasaadhee ghooleeaai || look karat bikaar bikhaRe prabh ner hoo te neriaa || binava(n)t naanak dhiaa dhaarahu kaadd bhavajal feriaa ||1||' })); | |||
| .toBe(JSON.stringify({ | |||
There was a problem hiding this comment.
Is one test enough?
|
@ManjotS please follow up here |
* English updates (#30) * Added rules for english cleanup, remove extra vowels in specific words guramukh, gurabani, guradhev, gurasikh, manamukh * words that start with ooRa like updesh should be updesh not aupdesh * [WIP] Hindi Translit (#19) * Initial Commit * Add better support * register hindi in translit.js * Add some more fixes to hindi * rename to devnagri * updated to add all characters required Some still need devnagri equivalent * Update devnagri.js * Update devnagri.js * Update devnagri.js * Update tests * remove prettier * ignore broken tests * Update LICENSE.md (#32) * Update package.json * Adds more tests for translit function; corrects output in comments of code * Removes changes from .eslintignore and .gitignore
navdeepsinghkhalsa
approved these changes
Feb 5, 2019
|
This was actually a part of Guaravjeet Singh's work...
…On Tue, Feb 5, 2019 at 5:33 AM Navdeep Singh ***@***.***> wrote:
Merged #31 <#31> into
master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#31 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAnXFWpq6K-z8uA39mJufz7ruQnbbxoyks5vKYgbgaJpZM4Wn8db>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.