Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code formatting with Prettier #40

Closed
wants to merge 2 commits into from
Closed

Conversation

navdeepsinghkhalsa
Copy link
Contributor

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 230

  • 22 of 24 (91.67%) changed or added relevant lines in 7 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 93.253%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/translit_modules/english.js 6 7 85.71%
src/translit_modules/ipa.js 6 7 85.71%
Files with Coverage Reduction New Missed Lines %
src/translit_modules/ipa.js 1 88.06%
Totals Coverage Status
Change from base Build 228: 0.03%
Covered Lines: 230
Relevant Lines: 241

💛 - Coveralls

{
"printWidth": 100,
"singleQuote": true,
"trailingComma": "all",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you okay with trailing commas in function call?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It's never been an issue :)

@ManjotS
Copy link
Collaborator

ManjotS commented Nov 6, 2019

I think this may be out of date now..

@ManjotS ManjotS closed this Nov 11, 2019
@tsingh777 tsingh777 deleted the code-formatting branch April 28, 2020 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants