Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support \underline in text mode #1159

Merged
merged 2 commits into from
Feb 14, 2018
Merged

Support \underline in text mode #1159

merged 2 commits into from
Feb 14, 2018

Conversation

edemaine
Copy link
Member

Fix #1158 with a one-line change. I could not find any other "long accents" that are supposed to work in text mode, but let me know if you find any!

Screenshot:
image

Comparison to LaTeX:
image

@codecov
Copy link

codecov bot commented Feb 14, 2018

Codecov Report

Merging #1159 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1159   +/-   ##
=======================================
  Coverage   79.37%   79.37%           
=======================================
  Files          59       59           
  Lines        3865     3865           
  Branches      648      648           
=======================================
  Hits         3068     3068           
  Misses        662      662           
  Partials      135      135
Impacted Files Coverage Δ
src/functions/underline.js 8.33% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 439cea3...b823a50. Read the comment docs.

ry-randall
ry-randall previously approved these changes Feb 14, 2018
Copy link
Member

@ry-randall ry-randall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad this was a simple/quick fix!

@ry-randall
Copy link
Member

@edemaine Meant to mention prior to approving. Perhaps we'd want to add a test for this? Might be able to add to the existing "Text" screenshot.

@edemaine
Copy link
Member Author

I added a simple test to the LowerAccent one which currently tests \underline. Let me know what you think!

Copy link
Member

@ry-randall ry-randall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test. Glad this was a simple fix!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants