One strut instead of two #1307
Merged
One strut instead of two #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggested in KaTeX#1287 (comment) the two struts were redundant; the formerly "bottom" strut suffices to implement both height and depth constraints.
Codecov Report
@@ Coverage Diff @@
## master #1307 +/- ##
==========================================
- Coverage 84.25% 84.24% -0.01%
==========================================
Files 61 61
Lines 3975 3973 -2
Branches 662 662
==========================================
- Hits 3349 3347 -2
Misses 532 532
Partials 94 94
Continue to review full report at Codecov.
|
ylemkimon
approved these changes
May 11, 2018
|
@edemaine cool! Thanks for making that change. I'm glad to see that almost all of the screenshot didn't change at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #1287 (comment) the two struts were redundant; the formerly "bottom" strut suffices to implement both height and depth constraints.
There is a slight vertical offset in a few screenshots. My investigation suggests this might be only an improvement: it seems that the element bounding boxes of the
.baseelement, as viewed by Chrome's inspector, is now correct (at least vertically):New:
Old:
The bounding box of the higher elements is still weird (not tall enough), but it's a step in the right direction.