Improve \sqrt

[ronkok]

Make \sqrt out of inline SVGs to ensure a perfect match at the junction between surd and viniculum.

[kevinbarabash]

Green is LaTeX, red is KaTeX. The spacing between the horizontal rules in the superscripts is improved over the last iteration of the inline SVG.

[kevinbarabash]

Some of the radical symbols seem to be missing padding on the left that's built into the glyph.

before:

after:

Highlighting the outermost sqrt of the first superscript shows that there is no left padding in that sqrt.

The large sqrt symbols seem to be the ones that are affected as there should be a gap between the first superscript and the second. There should also be more space to the left of the leftmost sqrt.

I looked at KaTeX_Size1-Regular and KaTeX_Size2-Regular fonts in opentype.js to confirm that there is indeed left padding built into the glyphs.

@ronkok can you update the inline SVGs to include the missing left padding? Sorry for not catching this in in the original review.

[ronkok]

I was hoping to avoid this. I didn't catch it before I minified the SVG code. Before that point, I have things somewhat automated, but afterwards a change is pretty tedious. No matter. I'll do it.

I have already added the correct leading advance to the main surd. I'll go and do the other five.

[kevinbarabash]

Before that point, I have things somewhat automated, but afterwards a change is pretty tedious. No matter. I'll do it.

Do you have a script? Would it be possible to add the padding via bounding box change?

[ronkok]

I have scripts that do matrix transformations of the original geometry. I shift all of them so that the SVG has no negative coordinates, because IE 9 reportedly doesn't deal well with negative coordinates.

But then there are non-scripted changes to make the viniculum absurdly long. And the tall surd got some custom changes of its own.

Don't worry about it. I have found copies from an intermediate step in the process. That will make things pretty easy for sizes 1 thru 4.

[ronkok]

@kevinbarabash It turned out to be pretty easy. Thank you for the nudge.

[kevinbarabash]

Left-padding on surds looks good now.

[kevinbarabash]

MathJax output for comparison.

[kevinbarabash]

LGTM

[kevinbarabash]

I'm glad you were able to simplify this.

[ronkok]

Yes, it took a few tries to focus in on the target, but we got there eventually. Thanks for your help and your patience.

[kevinbarabash]

@ronkok thank you so much for this PR. This fixes #60 which has been around for almost three years. \sqrt look awesome!

[edemaine]

Nice work guys!

[jpzwarte]

Very cool!