Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up inline-style-prefixer version #358

Merged
merged 1 commit into from
Feb 19, 2019
Merged

Conversation

cyejia
Copy link
Contributor

@cyejia cyejia commented Feb 8, 2019

This PR bumps the version of inline-style-prefixer up to 5.0.4 so that Aphrodite has the css logical plugin.

The imports in inline-style-prefixer changed from versions 4 to 5, so this PR also updates some of the import paths, and removes the compatibility: true option in generateData, which determined whether the plugin data generated used ES5 or ES2015 imports.

@khanbot
Copy link

khanbot commented Feb 8, 2019

Hey @chenyejia,

Thanks for the PR! Mind signing our Contributor License Agreement?

When you've done so, go ahead and comment [clabot:check] and I'll check again.

Yours truly,
khanbot

@cyejia
Copy link
Contributor Author

cyejia commented Feb 8, 2019

[clabot:check]

@khanbot
Copy link

khanbot commented Feb 8, 2019

CLA signature looks good 👍

@somewhatabstract
Copy link
Member

Does the loss of compatibility setting have any implications for Aphrodite usage after this lands?

@lencioni
Copy link
Collaborator

@somewhatabstract it looks like the compatibility flag only swaps between require or import for inline-style-prefixer plugins. More info in this PR: #361 (comment)

https://github.com/rofrischmann/inline-style-prefixer/blob/608ac33bd65d6732915745e74521b6475e1916d8/modules/generator/index.js#L5-L10

Since the require statement it generates does not use .default, the compatibility option breaks the aphrodite build.

TL;DR: I don't think this has any implications for Aphrodite usage after this lands.

@lencioni
Copy link
Collaborator

@chenyejia thanks for the PR!

@lencioni lencioni merged commit a9f69f4 into master Feb 19, 2019
@lencioni lencioni deleted the update-prefixer-dependency branch February 19, 2019 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants