Use deep import for inline-style-prefixer #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After updating to 2.3.0, I noticed a large bundle size increase. I believe this is due to switching this from a deep import to a named import, so we were duplicating a bunch of code (the named import used the es build, which brought in the es plugins, but our generated data brought in the lib plugins). As a quick fix, I think we can bring bundle sizes back down by using a deep import here again.
calinoracation
approved these changes
Feb 19, 2019
|
Bundlephobia is much happier with this. https://bundlephobia.com/result?p=aphrodite@2.3.1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating to 2.3.0, I noticed a large bundle size increase. I
believe this is due to switching this from a deep import to a named
import, so we were duplicating a bunch of code (the named import used
the es build, which brought in the es plugins, but our generated data
brought in the lib plugins).
As a quick fix, I think we can bring bundle sizes back down by using a
deep import here again.