Async + parallel rendering #390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @srolel, Thanks for the PR! Mind signing our Contributor License Agreement? When you've done so, go ahead and comment Yours truly, |
|
[clabot:check] |
|
CLA signature looks good 👍 |
|
Why was this closed and the branch deleted? |
|
Oh, huh -- I think it was closed automatically because I merged the PR that was the 2.4.0 branch. The branch that was deleted isn't the branch for this PR -- it was the branch this PR was targeting, which was from #382. I can't reopen it because the branch targeted by this PR no longer exists. |
|
ah, yeah that would do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes wrapping existing functionality in stateful classes, rather than having everything share the same global state. The API remains the same and all existing unit tests remain and pass.
In addition,
renderStaticAsyncis added which does what it sounds like, call a provided, asyncrenderFnand return a promise with the rendered html and css.Having stateful classes means we can instantiate them per request in the SSR use-case, this enabling parallel rendering.
note: PR into 2.4.0 since master is lagging behind it