Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to ensure output submodule is up to date. #21

Closed
itsjohncs opened this issue Jun 8, 2015 · 4 comments
Closed

Add test to ensure output submodule is up to date. #21

itsjohncs opened this issue Jun 8, 2015 · 4 comments

Comments

@itsjohncs
Copy link
Contributor

@itsjohncs itsjohncs commented Jun 8, 2015

Jordan ran into an error when publishing this morning because the output submodule wasn't updated after my last change. To prevent this in the future I should add a test that only runs when testing the gh-pages branch (which I hope I can do...) that will check where the master branches output submodule points to.

@itsjohncs
Copy link
Contributor Author

@itsjohncs itsjohncs commented Jun 8, 2015

It's also possible for the output submodule to be pointing too far ahead. Meaning the user hasn't pushed the output changes. This should also be checked for.

I think some more tooling in the makefile could help with this, as well as some docs to explain what's going on. Alternatively, it might make sense to drop the submodule stuff and do an alternative build process. That potentially won't be much easier though since we'll have to clone a separate repo or do some weird swapping stuff...

@itsjohncs
Copy link
Contributor Author

@itsjohncs itsjohncs commented Jun 8, 2015

I tweaked the deploy process to automate things a bit more, and make it clearer when things fail (like they did last night which caused this nonsense).

@sophiebits
Copy link
Contributor

@sophiebits sophiebits commented Jun 8, 2015

It's possible to have Travis run on master, build the site, and push automatically to gh-pages. That's what we do on React.

@itsjohncs
Copy link
Contributor Author

@itsjohncs itsjohncs commented Jun 8, 2015

Oh, that sounds like a solid workflow. I'll set that up, thank you @spicyj!

@itsjohncs itsjohncs closed this Jun 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.