Add test to ensure output submodule is up to date. #21

Closed
brownhead opened this Issue Jun 8, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@brownhead
Contributor

brownhead commented Jun 8, 2015

Jordan ran into an error when publishing this morning because the output submodule wasn't updated after my last change. To prevent this in the future I should add a test that only runs when testing the gh-pages branch (which I hope I can do...) that will check where the master branches output submodule points to.

@brownhead

This comment has been minimized.

Show comment
Hide comment
@brownhead

brownhead Jun 8, 2015

Contributor

It's also possible for the output submodule to be pointing too far ahead. Meaning the user hasn't pushed the output changes. This should also be checked for.

I think some more tooling in the makefile could help with this, as well as some docs to explain what's going on. Alternatively, it might make sense to drop the submodule stuff and do an alternative build process. That potentially won't be much easier though since we'll have to clone a separate repo or do some weird swapping stuff...

Contributor

brownhead commented Jun 8, 2015

It's also possible for the output submodule to be pointing too far ahead. Meaning the user hasn't pushed the output changes. This should also be checked for.

I think some more tooling in the makefile could help with this, as well as some docs to explain what's going on. Alternatively, it might make sense to drop the submodule stuff and do an alternative build process. That potentially won't be much easier though since we'll have to clone a separate repo or do some weird swapping stuff...

@brownhead

This comment has been minimized.

Show comment
Hide comment
@brownhead

brownhead Jun 8, 2015

Contributor

I tweaked the deploy process to automate things a bit more, and make it clearer when things fail (like they did last night which caused this nonsense).

Contributor

brownhead commented Jun 8, 2015

I tweaked the deploy process to automate things a bit more, and make it clearer when things fail (like they did last night which caused this nonsense).

@sophiebits

This comment has been minimized.

Show comment
Hide comment
@sophiebits

sophiebits Jun 8, 2015

Contributor

It's possible to have Travis run on master, build the site, and push automatically to gh-pages. That's what we do on React.

Contributor

sophiebits commented Jun 8, 2015

It's possible to have Travis run on master, build the site, and push automatically to gh-pages. That's what we do on React.

@brownhead

This comment has been minimized.

Show comment
Hide comment
@brownhead

brownhead Jun 8, 2015

Contributor

Oh, that sounds like a solid workflow. I'll set that up, thank you @spicyj!

Contributor

brownhead commented Jun 8, 2015

Oh, that sounds like a solid workflow. I'll set that up, thank you @spicyj!

@brownhead brownhead closed this Jun 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment