Skip to content
This repository has been archived by the owner on Dec 5, 2018. It is now read-only.

Commit

Permalink
Get rid of a special case: I removed the offending print statement!
Browse files Browse the repository at this point in the history
Summary:
The bug was fixed in rGWA311d4d5ebb8def10bedd730a4aac6e42e24e83da.
Once that's deployed, this will be safe to deploy as well.

Test Plan: Fingers crossed

Reviewers: tom

Reviewed By: tom

Subscribers: davidwang

Differential Revision: https://phabricator.khanacademy.org/D18878
  • Loading branch information
csilvers committed Jun 26, 2015
1 parent 9eab5b9 commit 978de91
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions models.py
Expand Up @@ -355,13 +355,6 @@ def _parse_message(message, status, level):

# Special-cases
error_def['id3'] = None
if error_def['title'].startswith("{'report_url':"):
# TODO(tom) Not sure where this error (which is just a bit of JSON
# without context) is being emitted. The most likely data structure
# this could be is the serializable version of UserAssessment in
# assessment/models.py. Would be nice to track this down so we can
# remove the special-case.
error_def['id3'] = id_prefix + 'report_url'

# Build a hash of the identifiers to serve as a single unique
# identifier for the error
Expand Down

0 comments on commit 978de91

Please sign in to comment.