make output deterministic for graphql interfaces #209
Conversation
vikstrous2
requested review from
benjaminjkraft,
csilvers,
dnerdy and
StevenACoffman
as code owners
|
@vikstrous2 Looks like some test failures |
|
Huh, I'm a bit surprised since we've never run into this in the tests (or at Khan as far as I know). I'm guessing the issue is actually if you have multiple schema files and the order they get read in is nondeterministic, or something. But anyway, it makes good sense to make this more stable even if in principle we could solve it elsewhere, so I'm happy to merge once tests are updated. For the tests, it should just be |
Signed-off-by: Steve Coffman <steve@khanacademy.org>
|
Yeah, I ran |
|
Ah! It looks like we also just need |
The generated files for integration tests aren't strictly snapshots and so `UPDATE_SNAPSHOTS=1` won't work (maybe we should make it work?). Instead you also need to `go generate ./...`. This came up in #209.
|
Ok, there we go! |
The generated files for integration tests aren't strictly snapshots and so `UPDATE_SNAPSHOTS=1` won't work (maybe we should make it work?). Instead you also need to `go generate ./...`. This came up in #209.
In #209, @vikstrous2 added a bugfix to sort the list of interfaces when generating code, so the generated output was stable. This worked great, but there was one more case where we need to do that, involving interfaces in fragments.
…ts. (#323) In #209, @vikstrous2 added a bugfix to sort the list of interfaces when generating code, so the generated output was stable. This worked great, but there was one more case where we need to do that, involving interfaces in fragments. I have: - [x] Written a clear PR title and description (above) - [x] Signed the [Khan Academy CLA](https://www.khanacademy.org/r/cla) - [x] Added tests covering my changes, if applicable - [ ] Included a link to the issue fixed, if applicable - [ ] Included documentation, for new features - [x] Added an entry to the changelog
We noticed that the output from genqlient can be non-deterministic when a graphql query queries a field that's an interface. This PR fixes that by sorting the types as soon as we extract them from the schema.
The snapshots for the tests need to be updated, but I don't know an easy way to do that. Is there a command or a flag that I can just flip somewhere to update them?
I have: