Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: There is currently a regression bug with autosuggest that will not get fixed in the next few weeks, so we've decided to disable it entirely. I saw a few different places I could disable it -- I could also do it in live-editor.js, tooltipEngine.setEnabledStatus. That code confuses me since setEnabledStatus actually only sets the enabled status of autosuggest, from what I can tell, but it might be the better place to disable it. What do you think? Test Plan: - Create new program at /cs/new/pjs. Type ba, don't see autosuggest. Type rect, see documentation tooltip popup. Complete rect command, be able to use number scrubbers. Type fill, use color picker successfully. Reviewers: kevinb Reviewed By: kevinb Subscribers: #cs Differential Revision: https://phabricator.khanacademy.org/D23704
- Loading branch information
4e028ca
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If autosuggest is disabled, shouldn't these tests be disabled for now?
4e028ca
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interestingly those tests passed: https://travis-ci.org/Khan/live-editor/builds/94219850. Not sure what's going on.