Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Interactive Graph Editor] Remove the use of graphKey for remounting (#…
…1385) ## Summary: It turns out that the use of `graphKey` for remounting in `interactive-graph-editor.tsx` is redundant, since this is also being done by the `useEffect` in `mafs-graph.tsx`. `graphKey` was also causing a warning to show up in the logs, possibly from a remounting loop. Here, `graphKey` is being removed altogether to stop the remounting issue. [More info on Slack](https://khanacademy.slack.com/archives/C067UM1QAR4/p1719854190583499) Issue: none ## Test plan: Storybook - http://localhost:6006/?path=/story/perseuseditor-editorpage--demo - Add an interactive graph - Open the browser console - Move the graph in the "correct" preview (quickly! Don't hold for time before dragging) - Confirm the warning doesn't appear - Change properties of the graph (e.g. number of segments) - Confirm that the preview changes correctly - Repeat for every graph type Author: nishasy Reviewers: benchristel, mark-fitzgerald, Myranae, SonicScrewdriver Required Reviewers: Approved By: benchristel Checks: ✅ gerald, ✅ codecov/project, ✅ codecov/patch, ✅ Upload Coverage (ubuntu-latest, 20.x), ⏭️ Publish npm snapshot, ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Jest Coverage (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x), ✅ gerald Pull Request URL: #1385
- Loading branch information