Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
🖍 _This is an audit!_ 🖍 The `skipMathJax` parameter to `Perseus.init()` controls whether MathJax 2 gets configured during the `init` call. This is gross because Perseus doesn't even import MathJax 2: it depends on a global `MathJax` variable existing whenever `skipMathJax` is not passed. `skipMathJax` is almost always being passed in webapp, except in a couple cases in the exercise editor where we need to use the legacy KaTeX+MathJax2 math renderer. The story referenced in the TODO comment is about removing that legacy renderer from webapp once all mobile app versions that use it have been deprecated. Once MathJax 2 is gone for good, we should be able to remove `skipMathJax` and the code it controls from Perseus. Issue: none ## Test plan: All CI checks should pass. Author: benchristel Auditors: Myranae, SonicScrewdriver Required Reviewers: Approved By: Myranae Checks: ✅ codecov/project, ✅ codecov/patch, ✅ Upload Coverage (ubuntu-latest, 20.x), ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Jest Coverage (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x), ✅ gerald Pull Request URL: #1358
- Loading branch information