Skip to content

Commit

Permalink
Trigger eslint-reset and jest-reset on package.json changes (#261)
Browse files Browse the repository at this point in the history
## Summary:

When the Changeset tool builds the "Version Packages" PR, it bumps the `package.json` files in this repo as-needed. We have Github actions that run ESLint and Flow for changes. In some cases, we want a full run and so we have the concept of a "reset" to trigger a full run. Any file listed in the reset list triggers the full run.

We had `yarn.lock` in the reset list for ESLint and Flow, but not `package.json`. Because `yarn.lock` isn't changed when we bump versions during a Changeset release, we were missing the full run we'd like to have. 

This PR adds `package.json` to the ESLint and Flow reset list.

Issue: "none"

## Test plan:

I'll land this and then check that the "Version Packages" PR that is already open does a full run of both ESLint and Flow. :fingers-crossed:

Author: jeremywiebe

Reviewers: kevinbarabash, jaredly

Required Reviewers:

Approved By: kevinbarabash

Checks: ✅ codecov/project, ✅ Lint, Flow, and Test (ubuntu-latest, 16.x), ✅ Extract i18n strings (ubuntu-latest, 16.x), ✅ Cypress Coverage (ubuntu-latest, 16.x), ✅ Check for .changeset file (ubuntu-latest, 16.x), ✅ Jest Coverage (ubuntu-latest, 16.x), ✅ gerald, ✅ Check builds for changes in size (ubuntu-latest, 16.x)

Pull Request URL: #261
  • Loading branch information
jeremywiebe committed Jun 6, 2022
1 parent 96288b8 commit dc20884
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 2 additions & 0 deletions .changeset/proud-carrots-love.md
@@ -0,0 +1,2 @@
---
---
4 changes: 2 additions & 2 deletions .github/workflows/node-ci.yml
Expand Up @@ -50,7 +50,7 @@ jobs:
name: Files that would trigger a full eslint run
with:
changed-files: ${{ steps.changed.outputs.files }}
files: '.eslintrc.js,yarn.lock,.eslintignore'
files: '.eslintrc.js,package.json,yarn.lock,.eslintignore'

# Linting / type checking
- name: Eslint
Expand All @@ -71,7 +71,7 @@ jobs:
name: Files that would trigger a full jest run
with:
changed-files: ${{ steps.changed.outputs.files }}
files: 'jest.config.js,yarn.lock,test.config.js,test.transform.js'
files: 'jest.config.js,package.json,yarn.lock,test.config.js,test.transform.js'

- name: Jest
uses: Khan/actions@full-or-limited-v0
Expand Down

0 comments on commit dc20884

Please sign in to comment.