[Dev UI] Wrap flipbook navigation controls in Toolbar #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
jeremywiebe
requested review from
benchristel,
SonicScrewdriver,
nishasy,
mark-fitzgerald,
handeyeco and
Myranae
|
Size Change: -1 B (0%) Total Size: 833 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1220 +/- ##
==========================================
+ Coverage 68.27% 70.04% +1.76%
==========================================
Files 466 472 +6
Lines 100600 100721 +121
Branches 7096 10791 +3695
==========================================
+ Hits 68684 70546 +1862
+ Misses 31801 30175 -1626
+ Partials 115 0 -115 see 127 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (d9c7466) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1220If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1220 |
handeyeco
approved these changes
Apr 26, 2024
Merged
benchristel
pushed a commit
that referenced
this pull request
May 6, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/math-input@18.1.0 ### Minor Changes - [#1230](#1230) [`db041577d`](db04157) Thanks [@benchristel](https://github.com/benchristel)! - Get `@khanacademy/mathjax-renderer` from NPM, to allow third-party clients of Perseus to install it ### Patch Changes - [#1205](#1205) [`71e74ff64`](71e74ff) Thanks [@benchristel](https://github.com/benchristel)! - Internal: Fix storybook stories for keypad button ## @khanacademy/perseus@22.3.0 ### Minor Changes - [#1210](#1210) [`2d3c3b49a`](2d3c3b4) Thanks [@nishasy](https://github.com/nishasy)! - Limit color set for locked figures in Interactive Graph ### Patch Changes - [#1231](#1231) [`4fae0155d`](4fae015) Thanks [@nishasy](https://github.com/nishasy)! - Adjust spacing in locked point and locked line settings - [#1232](#1232) [`cf1dc61b0`](cf1dc61) Thanks [@nishasy](https://github.com/nishasy)! - Refactor: separate LockedFigureSettingsAccordion component to reduce redundancy - [#1239](#1239) [`f757db589`](f757db5) Thanks [@benchristel](https://github.com/benchristel)! - Fix sizing of interactive graph axis labels on mobile - Updated dependencies \[[`71e74ff64`](71e74ff), [`db041577d`](db04157)]: - @khanacademy/math-input@18.1.0 ## @khanacademy/perseus-editor@6.2.0 ### Minor Changes - [#1210](#1210) [`2d3c3b49a`](2d3c3b4) Thanks [@nishasy](https://github.com/nishasy)! - Limit color set for locked figures in Interactive Graph ### Patch Changes - [#1231](#1231) [`4fae0155d`](4fae015) Thanks [@nishasy](https://github.com/nishasy)! - Adjust spacing in locked point and locked line settings - [#1232](#1232) [`cf1dc61b0`](cf1dc61) Thanks [@nishasy](https://github.com/nishasy)! - Refactor: separate LockedFigureSettingsAccordion component to reduce redundancy - Updated dependencies \[[`2d3c3b49a`](2d3c3b4), [`4fae0155d`](4fae015), [`71e74ff64`](71e74ff), [`cf1dc61b0`](cf1dc61), [`db041577d`](db04157), [`f757db589`](f757db5)]: - @khanacademy/perseus@22.3.0 - @khanacademy/math-input@18.1.0 ## @khanacademy/perseus-dev-ui@1.5.4 ### Patch Changes - [#1220](#1220) [`e3fd10f0e`](e3fd10f) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - ✨ Wrap the navigation controls of the Flipbook inside of a WB Toolbar - Updated dependencies \[[`71e74ff64`](71e74ff), [`db041577d`](db04157)]: - @khanacademy/math-input@18.1.0 Author: khan-actions-bot Reviewers: benchristel Required Reviewers: Approved By: benchristel Checks: ✅ codecov/project, ✅ codecov/patch, ✅ Upload Coverage, ⏭️ Publish npm snapshot, ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Jest Coverage (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ gerald Pull Request URL: #1228
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This little PR wraps the controls below the "Perseus JSON content" field of the Flipbook inside of a Toolbar. Subjective improvement? Maybe. :)
Issue: "none"
Test plan:
Run
yarn devand flip to the Flipbook 👀