Update mathjax-renderer to v2. #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
|
Size Change: +17 B (0%) Total Size: 833 kB
ℹ️ View Unchanged
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1235 +/- ##
==========================================
+ Coverage 68.75% 70.30% +1.55%
==========================================
Files 468 472 +4
Lines 100702 100769 +67
Branches 7141 10802 +3661
==========================================
+ Hits 69233 70841 +1608
+ Misses 31354 29928 -1426
+ Partials 115 0 -115
... and 125 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (1d30db3) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1235If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1235 |
Merged
jeresig
added a commit
that referenced
this pull request
May 8, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/math-input@19.0.0 ### Major Changes - [#1235](#1235) [`87169b22b`](87169b2) Thanks [@jeresig](https://github.com/jeresig)! - Update mathjax-renderer usage, locale is now required for createMathField. ## @khanacademy/perseus@22.4.1 ### Patch Changes - [#1240](#1240) [`4a59b85ab`](4a59b85) Thanks [@benchristel](https://github.com/benchristel)! - Change the tab order for movable line segments in interactive graphs. Previously, the order was `(whole segment, first point, second point)`. Now it's `(first point, whole segment, second point)`, which aligns better with the visual layout of the graph. - [#1240](#1240) [`4a59b85ab`](4a59b85) Thanks [@benchristel](https://github.com/benchristel)! - Adjust spacing in locked point and locked line settings - [#1235](#1235) [`87169b22b`](87169b2) Thanks [@jeresig](https://github.com/jeresig)! - Update mathjax-renderer usage, locale is now required for createMathField. - Updated dependencies \[[`87169b22b`](87169b2)]: - @khanacademy/math-input@19.0.0 ## @khanacademy/perseus-editor@6.2.2 ### Patch Changes - [#1247](#1247) [`99f32f531`](99f32f5) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Only show a11y banner for ruler and protractor when either or both is enabled - [#1240](#1240) [`4a59b85ab`](4a59b85) Thanks [@benchristel](https://github.com/benchristel)! - Adjust spacing in locked point and locked line settings - [#1235](#1235) [`87169b22b`](87169b2) Thanks [@jeresig](https://github.com/jeresig)! - Update mathjax-renderer usage, locale is now required for createMathField. - Updated dependencies \[[`4a59b85ab`](4a59b85), [`4a59b85ab`](4a59b85), [`87169b22b`](87169b2)]: - @khanacademy/perseus@22.4.1 - @khanacademy/math-input@19.0.0 ## @khanacademy/perseus-dev-ui@1.5.6 ### Patch Changes - Updated dependencies \[[`87169b22b`](87169b2)]: - @khanacademy/math-input@19.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This adds in a required locale param to createMathField, which is the biggest change, and technically a breaking change, so I'm going to do a major version bump on math-input.
Issue: FEI-5571
Test plan:
Tests all pass.