Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🔥AUDIT🔥] Fix stories that had a separator in the top-level name #1245

Merged
merged 2 commits into from
May 6, 2024

Conversation

jeremywiebe
Copy link
Collaborator

@jeremywiebe jeremywiebe commented May 6, 2024

🖍 This is an audit! 🖍

Summary:

I noticed that there were two components from the editor package that kept bubbling up to the top of the story listing in the "Perseus" area.

image

This was caused by having a / (separator) character in the name. Removing that moves the DeviceFramer and ViewportResizer stories down into the PerseusEditor area.

Issue: "none"

Test plan:

@jeremywiebe jeremywiebe self-assigned this May 6, 2024
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented May 6, 2024

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/violet-peaches-tie.md, packages/perseus-editor/src/components/__stories__/device-framer.stories.tsx, packages/perseus-editor/src/components/__stories__/viewport-resizer.stories.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@khan-actions-bot khan-actions-bot requested a review from a team May 6, 2024 21:30
Copy link
Contributor

github-actions bot commented May 6, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (b836e03) and published it to npm. You
can install it using the tag PR1245.

Example:

yarn add @khanacademy/perseus@PR1245

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1245

Copy link
Contributor

github-actions bot commented May 6, 2024

Size Change: 0 B

Total Size: 833 kB

ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.1 kB
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 80.5 kB
packages/math-input/dist/es/strings.js 1.73 kB
packages/perseus-core/dist/es/index.js 908 B
packages/perseus-editor/dist/es/index.js 267 kB
packages/perseus-error/dist/es/index.js 878 B
packages/perseus-linter/dist/es/index.js 21.8 kB
packages/perseus/dist/es/index.js 398 kB
packages/perseus/dist/es/strings.js 3.22 kB
packages/pure-markdown/dist/es/index.js 3.68 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.10%. Comparing base (44cf734) to head (b836e03).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1245      +/-   ##
==========================================
+ Coverage   68.78%   70.10%   +1.32%     
==========================================
  Files         470      474       +4     
  Lines      100733   100798      +65     
  Branches     7130    10201    +3071     
==========================================
+ Hits        69291    70669    +1378     
+ Misses      31257    30129    -1128     
+ Partials      185        0     -185     

Impacted file tree graph

see 143 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44cf734...b836e03. Read the comment docs.

@jeremywiebe jeremywiebe merged commit 45a6647 into main May 6, 2024
13 checks passed
@jeremywiebe jeremywiebe deleted the jer/story-fix branch May 6, 2024 21:45
nishasy added a commit that referenced this pull request May 7, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @khanacademy/perseus@22.4.0

### Minor Changes

- [#1229](#1229)
[`3c1e398d5`](3c1e398)
Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - Show
Arrowheads on Locked Lines in Interactive Graphs


- [#1237](#1237)
[`54689a18f`](54689a1)
Thanks [@handeyeco](https://github.com/handeyeco)! - Rough out new
Circle Graph behind a feature flag

### Patch Changes

- [#1222](#1222)
[`44cf7348c`](44cf734)
Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Fix
@phosphor-icon paths in `explanation` widget


- [#1243](#1243)
[`ee89a1b01`](ee89a1b)
Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Fix dash style
for locked lines when kind is 'ray'

## @khanacademy/perseus-editor@6.2.1

### Patch Changes

- [#1237](#1237)
[`54689a18f`](54689a1)
Thanks [@handeyeco](https://github.com/handeyeco)! - Rough out new
Circle Graph behind a feature flag


- [#1246](#1246)
[`d66b79e44`](d66b79e)
Thanks [@nishasy](https://github.com/nishasy)! - Change locked figures'
initial color to grayH (previusly green)


- [#1242](#1242)
[`7d172698e`](7d17269)
Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Adds a warning
above the protractor and ruler checkboxes in interactive-graph settings


- [#1245](#1245)
[`45a6647cf`](45a6647)
Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Fix location of
DeviceFramer and ViewportResizer in Storybook

- Updated dependencies
\[[`44cf7348c`](44cf734),
[`3c1e398d5`](3c1e398),
[`ee89a1b01`](ee89a1b),
[`54689a18f`](54689a1)]:
    -   @khanacademy/perseus@22.4.0

## @khanacademy/perseus-dev-ui@1.5.5

### Patch Changes

- [#1222](#1222)
[`44cf7348c`](44cf734)
Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - ✨ Display image
background info in Dev UI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants