Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useUniqueIdWithMock for label/id in Choice #1251

Merged
merged 3 commits into from
May 9, 2024
Merged

Conversation

handeyeco
Copy link
Contributor

We think useUniqueIdWithMock has a problem with certain languages

https://khanacademy.slack.com/archives/C01AZ9H8TTQ/p1715260865316979

@khan-actions-bot khan-actions-bot requested a review from a team May 9, 2024 14:23
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented May 9, 2024

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/young-mirrors-care.md, packages/perseus/src/widgets/radio/choice.tsx, packages/perseus/src/multi-items/__tests__/__snapshots__/multi-renderer.test.tsx.snap, packages/perseus/src/widgets/__tests__/__snapshots__/group.test.tsx.snap, packages/perseus/src/widgets/__tests__/__snapshots__/radio.test.ts.snap

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link
Contributor

github-actions bot commented May 9, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (51153a5) and published it to npm. You
can install it using the tag PR1251.

Example:

yarn add @khanacademy/perseus@PR1251

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1251

Copy link
Contributor

github-actions bot commented May 9, 2024

Size Change: -63 B (0%)

Total Size: 835 kB

Filename Size Change
packages/perseus/dist/es/index.js 400 kB -63 B (0%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.1 kB
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 80.5 kB
packages/math-input/dist/es/strings.js 1.73 kB
packages/perseus-core/dist/es/index.js 908 B
packages/perseus-editor/dist/es/index.js 267 kB
packages/perseus-error/dist/es/index.js 878 B
packages/perseus-linter/dist/es/index.js 21.8 kB
packages/perseus/dist/es/strings.js 3.22 kB
packages/pure-markdown/dist/es/index.js 3.68 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.00%. Comparing base (9fff34d) to head (51153a5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1251      +/-   ##
==========================================
+ Coverage   68.91%   70.00%   +1.09%     
==========================================
  Files         472      476       +4     
  Lines      101110   101173      +63     
  Branches     7207    10866    +3659     
==========================================
+ Hits        69680    70830    +1150     
+ Misses      31315    30343     -972     
+ Partials      115        0     -115     

Impacted file tree graph

Files Coverage Δ
packages/perseus/src/widgets/radio/choice.tsx 95.75% <100.00%> (-0.05%) ⬇️

... and 125 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fff34d...51153a5. Read the comment docs.

@handeyeco handeyeco requested a review from a team May 9, 2024 15:44
Copy link
Member

@jeresig jeresig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah great, thank you!

@handeyeco handeyeco merged commit 917a6da into main May 9, 2024
13 checks passed
@handeyeco handeyeco deleted the i18n-label-bug branch May 9, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants