-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove useUniqueIdWithMock for label/id in Choice #1251
Conversation
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (51153a5) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1251 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1251 |
Size Change: -63 B (0%) Total Size: 835 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1251 +/- ##
==========================================
+ Coverage 68.91% 70.00% +1.09%
==========================================
Files 472 476 +4
Lines 101110 101173 +63
Branches 7207 10866 +3659
==========================================
+ Hits 69680 70830 +1150
+ Misses 31315 30343 -972
+ Partials 115 0 -115
... and 125 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah great, thank you!
We think
useUniqueIdWithMock
has a problem with certain languageshttps://khanacademy.slack.com/archives/C01AZ9H8TTQ/p1715260865316979