-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update LockedLineSettings to reflect line kind in the summary #1254
Conversation
Size Change: +48 B (0%) Total Size: 835 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1254 +/- ##
==========================================
+ Coverage 68.91% 70.34% +1.42%
==========================================
Files 472 476 +4
Lines 101110 101179 +69
Branches 7207 10264 +3057
==========================================
+ Hits 69680 71171 +1491
+ Misses 31315 30008 -1307
+ Partials 115 0 -115
... and 126 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (18ffdef) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1254 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1254 |
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/math-input@19.1.0 ### Minor Changes - [#1259](#1259) [`c07644f63`](c07644f) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Update all Perseus peer dependencies to match webapp exactly (commit: 2bd290251a8) - @khanacademy/wonder-blocks-clickable v4.2.1 - @khanacademy/wonder-blocks-core v6.4.0 - @khanacademy/wonder-blocks-popover v3.2.2 - @khanacademy/wonder-blocks-timing v5.0.0 - @khanacademy/wonder-blocks-tokens v1.3.0 - @khanacademy/wonder-stuff-core v1.5.2 - aphrodite v1.2.5 - katex v0.11.1 - react v16.14.0 - react-router v5.2.1 - react-router-dom v5.3.0 ## @khanacademy/perseus@22.5.0 ### Minor Changes - [#1259](#1259) [`c07644f63`](c07644f) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Update all Perseus peer dependencies to match webapp exactly (commit: 2bd290251a8) - @khanacademy/wonder-blocks-banner v3.0.42 - @khanacademy/wonder-blocks-button v6.3.1 - @khanacademy/wonder-blocks-clickable v4.2.1 - @khanacademy/wonder-blocks-core v6.4.0 - @khanacademy/wonder-blocks-data v13.0.7 - @khanacademy/wonder-blocks-dropdown v5.3.0 - @khanacademy/wonder-blocks-form v4.5.1 - @khanacademy/wonder-blocks-icon v4.1.0 - @khanacademy/wonder-blocks-layout v2.0.32 - @khanacademy/wonder-blocks-link v6.1.1 - @khanacademy/wonder-blocks-pill v2.2.1 - @khanacademy/wonder-blocks-popover v3.2.2 - @khanacademy/wonder-blocks-progress-spinner v2.1.1 - @khanacademy/wonder-blocks-switch v1.1.16 - @khanacademy/wonder-blocks-tokens v1.3.0 - @khanacademy/wonder-blocks-tooltip v2.3.1 - @khanacademy/wonder-blocks-typography v2.1.11 - @khanacademy/wonder-stuff-core v1.5.2 - @popperjs/core v^2.10.2 - classnames v1.1.4 - create-react-class v15.6.3 - katex v0.11.1 - prop-types v15.6.1 - react-popper v^2.2.5 - [#1261](#1261) [`f92c52412`](f92c524) Thanks [@Myranae](https://github.com/Myranae)! - Fix bug where arrow keys did not move all line segments ### Patch Changes - [#1256](#1256) [`9e2f404bb`](9e2f404) Thanks [@benchristel](https://github.com/benchristel)! - Update the styling of interactive circle graphs rendered with Mafs - [#1263](#1263) [`1f03243ba`](1f03243) Thanks [@benchristel](https://github.com/benchristel)! - Fix a bug in Mafs linear graphs where the arrows on the ends of the lines would sometimes disappear or flip around - [#1260](#1260) [`896a159a6`](896a159) Thanks [@nishasy](https://github.com/nishasy)! - Rename "start point" and "end point" to "point 1" and "point 2" respectively in Interactive Graph locked line settings - [#1250](#1250) [`3806759ea`](3806759) Thanks [@benchristel](https://github.com/benchristel)! - Internal: Refactor MovableLine component - Updated dependencies \[[`c07644f63`](c07644f), [`c07644f63`](c07644f)]: - @khanacademy/perseus-linter@0.4.0 - @khanacademy/math-input@19.1.0 - @khanacademy/pure-markdown@0.3.4 ## @khanacademy/perseus-editor@6.3.0 ### Minor Changes - [#1265](#1265) [`ef684516c`](ef68451) Thanks [@nishasy](https://github.com/nishasy)! - LockedLineSettings summary now uses a line swatch instead of a color swatch - [#1259](#1259) [`c07644f63`](c07644f) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Update all Perseus peer dependencies to match webapp exactly (commit: 2bd290251a8) - @khanacademy/wonder-blocks-accordion v1.3.1 - @khanacademy/wonder-blocks-button v6.3.1 - @khanacademy/wonder-blocks-banner v3.0.42 - @khanacademy/wonder-blocks-clickable v4.2.1 - @khanacademy/wonder-blocks-core v6.4.0 - @khanacademy/wonder-blocks-dropdown v5.3.0 - @khanacademy/wonder-blocks-form v4.5.1 - @khanacademy/wonder-blocks-icon-button v5.2.1 - @khanacademy/wonder-blocks-switch v1.1.16 - @khanacademy/wonder-blocks-tooltip v2.3.1 - @khanacademy/wonder-blocks-tokens v1.3.0 - @khanacademy/wonder-blocks-typography v2.1.11 - @khanacademy/wonder-stuff-core v1.5.2 - classnames v1.1.4 - create-react-class v15.6.3 - prop-types v15.6.1 ### Patch Changes - [#1260](#1260) [`896a159a6`](896a159) Thanks [@nishasy](https://github.com/nishasy)! - Rename "start point" and "end point" to "point 1" and "point 2" respectively in Interactive Graph locked line settings - [#1262](#1262) [`88c48a784`](88c48a7) Thanks [@nishasy](https://github.com/nishasy)! - Locked line coordinates update on input change instead of on input blur - [#1254](#1254) [`e4b893c76`](e4b893c) Thanks [@nishasy](https://github.com/nishasy)! - Locked line summary reflects line kind - Updated dependencies \[[`9e2f404bb`](9e2f404), [`1f03243ba`](1f03243), [`896a159a6`](896a159), [`3806759ea`](3806759), [`c07644f63`](c07644f), [`c07644f63`](c07644f), [`f92c52412`](f92c524)]: - @khanacademy/perseus@22.5.0 - @khanacademy/math-input@19.1.0 ## @khanacademy/perseus-error@0.3.0 ### Minor Changes - [#1259](#1259) [`c07644f63`](c07644f) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Update all Perseus peer dependencies to match webapp exactly (commit: 2bd290251a8) - @khanacademy/wonder-stuff-core v1.5.2 ## @khanacademy/perseus-linter@0.4.0 ### Minor Changes - [#1259](#1259) [`c07644f63`](c07644f) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Update all Perseus peer dependencies to match webapp exactly (commit: 2bd290251a8) - prop-types v15.6.1 ### Patch Changes - Updated dependencies \[[`c07644f63`](c07644f)]: - @khanacademy/perseus-error@0.3.0 ## @khanacademy/pure-markdown@0.3.4 ### Patch Changes - Updated dependencies \[[`c07644f63`](c07644f)]: - @khanacademy/perseus-error@0.3.0 ## @khanacademy/perseus-dev-ui@1.5.7 ### Patch Changes - Updated dependencies \[[`c07644f63`](c07644f), [`c07644f63`](c07644f)]: - @khanacademy/perseus-linter@0.4.0 - @khanacademy/math-input@19.1.0 - @khanacademy/pure-markdown@0.3.4
Summary:
It would be nice if the summary at the top of the locked line settings
accordion also showed what its kind is (line, segment, ray).
Adding that functionality here.
Issue: https://khanacademy.atlassian.net/browse/LEMS-1993
Test plan:
yarn jest packages/perseus-editor/src/components/__tests__/locked-line-settings.test.tsx
Storybook