Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Interactive Graph Editor] Add locked vector to storybook story for all locked figures #1350

Merged
merged 5 commits into from
Jun 17, 2024

Commits on Jun 13, 2024

  1. [Interactive Graph Editor] Update the locked ellipse settings so they…

    … only take degrees for the angle input
    
    We had it so that locked ellipse settings allow for either degrees or radians
    for the angel input. However, I realized that we're not saving the data for
    what unit is being used. This means that if an angle were saved as "30 degrees"
    and then the page were reloaded, it would then show up as "0.523599 radians".
    
    For the sake of simplicty and consistency, I'm changing this so that it only
    takes degrees, and I'm changing it to a number input since it no longer needs
    to evaluate expressions with pi (that required it being a text input).
    
    Issue: https://khanacademy.atlassian.net/browse/LEMS-1941
    
    Test plan:
    `yarn jest`
    
    Storybook
    - http://localhost:6006/?path=/story/perseuseditor-editorpage--mafs-with-locked-figures-m-2-flag
    - Confirm that the ellipse settings angle input shows degrees only
    - Confirm that it is rotated correctly
    nishasy committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    a76359e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    49bbb4e View commit details
    Browse the repository at this point in the history
  3. [Interactive Graph Editor] Add locked vector to storybook story for a…

    …ll locked figures
    
    Super minor. Just adding a locked vector to the `segmentWithLockedFigures`
    testdata so that the stories with all locked figures show all the current
    locked figures.
    
    Issue: none
    
    Test plan:
    http://localhost:6006/?path=/story/perseuseditor-editorpage--mafs-with-locked-figures-m-2-flag
    
    confirm all four locked figure types' settings are there
    nishasy committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    168b6a6 View commit details
    Browse the repository at this point in the history
  4. lint

    nishasy committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    7970b98 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Configuration menu
    Copy the full SHA
    2489507 View commit details
    Browse the repository at this point in the history