Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Interactive Graph Editor] Add the ability to reorder locked figure settings #1360

Merged
merged 5 commits into from
Jun 20, 2024

Commits on Jun 17, 2024

  1. [Interactive Graph Editor] Update the locked ellipse settings so they…

    … only take degrees for the angle input
    
    We had it so that locked ellipse settings allow for either degrees or radians
    for the angel input. However, I realized that we're not saving the data for
    what unit is being used. This means that if an angle were saved as "30 degrees"
    and then the page were reloaded, it would then show up as "0.523599 radians".
    
    For the sake of simplicty and consistency, I'm changing this so that it only
    takes degrees, and I'm changing it to a number input since it no longer needs
    to evaluate expressions with pi (that required it being a text input).
    
    Issue: https://khanacademy.atlassian.net/browse/LEMS-1941
    
    Test plan:
    `yarn jest`
    
    Storybook
    - http://localhost:6006/?path=/story/perseuseditor-editorpage--mafs-with-locked-figures-m-2-flag
    - Confirm that the ellipse settings angle input shows degrees only
    - Confirm that it is rotated correctly
    nishasy committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    b430df8 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Configuration menu
    Copy the full SHA
    06be925 View commit details
    Browse the repository at this point in the history
  2. [Interactive Graph Editor] Add the ability to reorder locked figure s…

    …ettings
    
    Added some icon buttons so that content authors can reorder the locked figure
    settings. This can be used to make sure that one figure can render on top
    of another figure as desired. (The lower they are in the settings, the more
    in the front they are on the graph.)
    
    Issue: https://khanacademy.atlassian.net/browse/LEMS-1951
    
    Test plan:
    todo
    nishasy committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    8a2da06 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Remove omit. Change to back/front instead of top/bottom. Keep the exp…

    …anded state array updated with the movement.
    nishasy committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    e79e001 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    769f454 View commit details
    Browse the repository at this point in the history