Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Interactive Graph Editor] Put the action buttons under the m2 flag #1365

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

nishasy
Copy link
Contributor

@nishasy nishasy commented Jun 20, 2024

Summary:

The action buttons that were added in #1360
need to be behind the m2 flag. Adding the check here.

Issue: https://khanacademy.atlassian.net/browse/LEMS-1951

Test plan:

Storybook

Current

Screenshot 2024-06-20 at 2 02 23 PM

M2 flag

Screenshot 2024-06-20 at 2 02 39 PM Screenshot 2024-06-20 at 2 02 46 PM

@nishasy nishasy self-assigned this Jun 20, 2024
Copy link
Contributor

Size Change: +6 B (0%)

Total Size: 846 kB

Filename Size Change
packages/perseus-editor/dist/es/index.js 272 kB +6 B (0%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.2 kB
packages/kmath/dist/es/index.js 4.26 kB
packages/math-input/dist/es/index.js 80.1 kB
packages/math-input/dist/es/strings.js 1.73 kB
packages/perseus-core/dist/es/index.js 906 B
packages/perseus-error/dist/es/index.js 866 B
packages/perseus-linter/dist/es/index.js 21.8 kB
packages/perseus/dist/es/index.js 407 kB
packages/perseus/dist/es/strings.js 3.21 kB
packages/pure-markdown/dist/es/index.js 3.67 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

@nishasy nishasy marked this pull request as ready for review June 20, 2024 21:12
@khan-actions-bot khan-actions-bot requested a review from a team June 20, 2024 21:13
@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/funny-sheep-retire.md, packages/perseus-editor/src/components/locked-ellipse-settings.tsx, packages/perseus-editor/src/components/locked-figure-settings-actions.tsx, packages/perseus-editor/src/components/locked-line-settings.tsx, packages/perseus-editor/src/components/locked-point-settings.tsx, packages/perseus-editor/src/components/locked-polygon-settings.tsx, packages/perseus-editor/src/components/locked-vector-settings.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@nishasy nishasy requested a review from benchristel June 20, 2024 21:15
Copy link
Contributor

@mark-fitzgerald mark-fitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's too bad that we don't have a React Context way of accessing these flags so that we wouldn't need to pass it as a prop in so many places.

@nishasy
Copy link
Contributor Author

nishasy commented Jun 20, 2024

@mark-fitzgerald I agree! I think it would make sense for API options to be a context.

@nishasy nishasy merged commit 33adc62 into main Jun 20, 2024
14 of 20 checks passed
@nishasy nishasy deleted the put-reorder-buttons-behind-flag branch June 20, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants