Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Interactive Graph Editor] Add locked features M2b flag #1366

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Conversation

nishasy
Copy link
Contributor

@nishasy nishasy commented Jun 20, 2024

Summary:

Adding the m2b flag and its prop to all the relevant components.

This way, it should be easy to use a simple conditional when we add
the upcoming locked figures (function graphs, labels, maybe polygon markings).

Issue: none

Test plan:

@nishasy nishasy self-assigned this Jun 20, 2024
Copy link
Contributor

Size Change: +46 B (+0.01%)

Total Size: 846 kB

Filename Size Change
packages/perseus-editor/dist/es/index.js 272 kB +46 B (+0.02%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.2 kB
packages/kmath/dist/es/index.js 4.26 kB
packages/math-input/dist/es/index.js 80.1 kB
packages/math-input/dist/es/strings.js 1.73 kB
packages/perseus-core/dist/es/index.js 906 B
packages/perseus-error/dist/es/index.js 866 B
packages/perseus-linter/dist/es/index.js 21.8 kB
packages/perseus/dist/es/index.js 407 kB
packages/perseus/dist/es/strings.js 3.21 kB
packages/pure-markdown/dist/es/index.js 3.67 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

@nishasy nishasy marked this pull request as ready for review June 20, 2024 21:51
@khan-actions-bot khan-actions-bot requested a review from a team June 20, 2024 21:51
@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/sour-coats-agree.md, packages/perseus/src/types.ts, packages/perseus-editor/src/__stories__/editor-page.stories.tsx, packages/perseus-editor/src/__stories__/flags-for-api-options.ts, packages/perseus-editor/src/components/locked-figure-select.tsx, packages/perseus-editor/src/components/locked-figure-settings.tsx, packages/perseus-editor/src/components/locked-figures-section.tsx, packages/perseus-editor/src/widgets/interactive-graph-editor.tsx, packages/perseus-editor/src/components/__stories__/locked-figures-section.stories.tsx, packages/perseus-editor/src/components/__tests__/locked-figures-section.test.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.96%. Comparing base (753d6ea) to head (def29ff).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1366      +/-   ##
==========================================
+ Coverage   69.51%   70.96%   +1.44%     
==========================================
  Files         491      495       +4     
  Lines      103819   103909      +90     
  Branches     7435    11220    +3785     
==========================================
+ Hits        72174    73734    +1560     
+ Misses      31462    30175    -1287     
+ Partials      183        0     -183     

Impacted file tree graph

Files Coverage Δ
...eus-editor/src/components/locked-figure-select.tsx 100.00% <100.00%> (ø)
...s-editor/src/components/locked-figure-settings.tsx 94.25% <100.00%> (+0.20%) ⬆️
...s-editor/src/components/locked-figures-section.tsx 100.00% <100.00%> (ø)
...us-editor/src/widgets/interactive-graph-editor.tsx 90.52% <100.00%> (+0.06%) ⬆️

... and 141 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 753d6ea...def29ff. Read the comment docs.

Copy link
Contributor

@mark-fitzgerald mark-fitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2b or not 2b? That is a boolean. (sorry, Shakespeare)

@nishasy nishasy merged commit 1351ca3 into main Jun 20, 2024
14 checks passed
@nishasy nishasy deleted the create-m2b-flag branch June 20, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants