Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize locked figures into own folder #1368

Merged
merged 5 commits into from
Jun 20, 2024

Conversation

mark-fitzgerald
Copy link
Contributor

The number of files dedicated to locked figures has reached a point where we should group them for better organization.

@khan-actions-bot khan-actions-bot requested a review from a team June 20, 2024 22:38
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Jun 20, 2024

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/giant-shoes-wait.md, packages/perseus-editor/src/components/interactive-graph-settings.tsx, packages/perseus-editor/src/widgets/interactive-graph-editor.tsx, packages/perseus/src/widgets/interactive-graphs/graph-locked-layer.tsx, packages/perseus-editor/src/components/__stories__/color-select.stories.tsx, packages/perseus-editor/src/components/__stories__/color-swatch.stories.tsx, packages/perseus-editor/src/components/__stories__/locked-ellipse-settings.stories.tsx, packages/perseus-editor/src/components/__stories__/locked-figures-section.stories.tsx, packages/perseus-editor/src/components/__stories__/locked-line-settings.stories.tsx, packages/perseus-editor/src/components/__stories__/locked-point-settings.stories.tsx, packages/perseus-editor/src/components/__stories__/locked-polygon-settings.stories.tsx, packages/perseus-editor/src/components/__stories__/locked-vector-settings.stories.tsx, packages/perseus-editor/src/components/__tests__/locked-ellipse-settings.test.tsx, packages/perseus-editor/src/components/__tests__/locked-figures-section.test.tsx, packages/perseus-editor/src/components/__tests__/locked-line-settings.test.tsx, packages/perseus-editor/src/components/__tests__/locked-point-settings.test.tsx, packages/perseus-editor/src/components/__tests__/locked-polygon-settings.test.tsx, packages/perseus-editor/src/components/__tests__/locked-vector-settings.test.tsx, packages/perseus-editor/src/components/graph-locked-figures/color-select.tsx, packages/perseus-editor/src/components/graph-locked-figures/color-swatch.tsx, packages/perseus-editor/src/components/graph-locked-figures/coordinate-pair-input.tsx, packages/perseus-editor/src/components/graph-locked-figures/defining-point-settings.tsx, packages/perseus-editor/src/components/graph-locked-figures/ellipse-swatch.tsx, packages/perseus-editor/src/components/graph-locked-figures/labeled-row.tsx, packages/perseus-editor/src/components/graph-locked-figures/labeled-switch.tsx, packages/perseus-editor/src/components/graph-locked-figures/line-swatch.tsx, packages/perseus-editor/src/components/graph-locked-figures/locked-ellipse-settings.tsx, packages/perseus-editor/src/components/graph-locked-figures/locked-figure-select.tsx, packages/perseus-editor/src/components/graph-locked-figures/locked-figure-settings-accordion.tsx, packages/perseus-editor/src/components/graph-locked-figures/locked-figure-settings-actions.tsx, packages/perseus-editor/src/components/graph-locked-figures/locked-figure-settings.tsx, packages/perseus-editor/src/components/graph-locked-figures/locked-figures-section.tsx, packages/perseus-editor/src/components/graph-locked-figures/locked-line-settings.tsx, packages/perseus-editor/src/components/graph-locked-figures/locked-point-settings.tsx, packages/perseus-editor/src/components/graph-locked-figures/locked-polygon-settings.tsx, packages/perseus-editor/src/components/graph-locked-figures/locked-vector-settings.tsx, packages/perseus-editor/src/components/graph-locked-figures/polygon-swatch.tsx, packages/perseus/src/widgets/interactive-graphs/locked-figures/locked-ellipse.tsx, packages/perseus/src/widgets/interactive-graphs/locked-figures/locked-line.tsx, packages/perseus/src/widgets/interactive-graphs/locked-figures/locked-point.tsx, packages/perseus/src/widgets/interactive-graphs/locked-figures/locked-polygon.tsx, packages/perseus/src/widgets/interactive-graphs/locked-figures/locked-vector.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link
Contributor

github-actions bot commented Jun 20, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (525ea1d) and published it to npm. You
can install it using the tag PR1368.

Example:

yarn add @khanacademy/perseus@PR1368

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1368

Copy link
Contributor

github-actions bot commented Jun 20, 2024

Size Change: -240 B (-0.03%)

Total Size: 846 kB

Filename Size Change
packages/perseus-editor/dist/es/index.js 272 kB -240 B (-0.09%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.2 kB
packages/kmath/dist/es/index.js 4.26 kB
packages/math-input/dist/es/index.js 80.1 kB
packages/math-input/dist/es/strings.js 1.73 kB
packages/perseus-core/dist/es/index.js 906 B
packages/perseus-error/dist/es/index.js 866 B
packages/perseus-linter/dist/es/index.js 21.8 kB
packages/perseus/dist/es/index.js 407 kB
packages/perseus/dist/es/strings.js 3.21 kB
packages/pure-markdown/dist/es/index.js 3.67 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.90%. Comparing base (1351ca3) to head (525ea1d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1368      +/-   ##
==========================================
+ Coverage   69.83%   70.90%   +1.07%     
==========================================
  Files         491      495       +4     
  Lines      103846   103924      +78     
  Branches     7491    11193    +3702     
==========================================
+ Hits        72516    73688    +1172     
+ Misses      31152    30236     -916     
+ Partials      178        0     -178     

Impacted file tree graph

Files Coverage Δ
...c/components/graph-locked-figures/color-select.tsx 100.00% <ø> (ø)
...c/components/graph-locked-figures/color-swatch.tsx 97.91% <ø> (ø)
...nts/graph-locked-figures/coordinate-pair-input.tsx 100.00% <ø> (ø)
...s/graph-locked-figures/defining-point-settings.tsx 100.00% <ø> (ø)
...components/graph-locked-figures/ellipse-swatch.tsx 100.00% <ø> (ø)
...rc/components/graph-locked-figures/labeled-row.tsx 98.07% <ø> (ø)
...components/graph-locked-figures/labeled-switch.tsx 100.00% <ø> (ø)
...rc/components/graph-locked-figures/line-swatch.tsx 100.00% <ø> (ø)
...s/graph-locked-figures/locked-ellipse-settings.tsx 100.00% <100.00%> (ø)
...ents/graph-locked-figures/locked-figure-select.tsx 100.00% <ø> (ø)
... and 17 more

... and 138 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1351ca3...525ea1d. Read the comment docs.

Copy link
Contributor

@nishasy nishasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@mark-fitzgerald mark-fitzgerald merged commit 86f94e1 into main Jun 20, 2024
13 checks passed
@mark-fitzgerald mark-fitzgerald deleted the organize-locked-figures-into-own-folder branch June 20, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants