Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEI-3775: Configure wallaby #152

Merged
merged 2 commits into from Apr 28, 2022
Merged

FEI-3775: Configure wallaby #152

merged 2 commits into from Apr 28, 2022

Conversation

kevinbarabash
Copy link
Member

@kevinbarabash kevinbarabash commented Apr 28, 2022

Summary:

I'm having troubles figuring out some of the test failures we're seeing in some of the widget tests so I thought I'd set up wallaby to help with continued debugging.

Issue: FEI-3775

Test plan:

  • doing an exclusive run on a couple of test files
  • see that coverage is being reported for the widget implementation file as well

Screen Shot 2022-04-28 at 10 40 33 AM

@kevinbarabash kevinbarabash self-assigned this Apr 28, 2022
@changeset-bot
Copy link

changeset-bot bot commented Apr 28, 2022

⚠️ No Changeset found

Latest commit: dd960ba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kevinbarabash kevinbarabash requested review from a team April 28, 2022 14:38
"!<rootDir>/node_modules/",
"!packages/**/node_modules/",
"packages/*/src/**/*.js",
"packages/*/src/**/*.jsx",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files were being missed so I wasn't seeing any coverage squares in the gutter for the implementation file.

Comment on lines +16 to +20
return {
autoDetect: true,
runMode: "onsave",
trace: true,
};
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't really notice a difference overriding files and tests so I went with this minimal config.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wallaby picks up our Jest config so the files and tests will come from there and should be correct. You can see the derived settings if you use the override key like we have in webapp and the console.log the incoming filePatterns or testPatterns

wallaby.js Outdated Show resolved Hide resolved
@kevinbarabash kevinbarabash merged commit 8070c69 into main Apr 28, 2022
@kevinbarabash kevinbarabash deleted the fei-3775 branch May 4, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants