-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEI-5042: Update wonder-blocks dependencies #419
Conversation
🦋 Changeset detectedLatest commit: 156633b The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Size Change: 0 B Total Size: 635 kB ℹ️ View Unchanged
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #419 +/- ##
==========================================
+ Coverage 65.50% 65.98% +0.48%
==========================================
Files 481 487 +6
Lines 103961 107108 +3147
Branches 5620 7376 +1756
==========================================
+ Hits 68095 70674 +2579
- Misses 35866 36434 +568 see 38 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@@ -63,7 +63,7 @@ exports[`video widget should snapshot on mobile: first mobile render 1`] = ` | |||
class="default_xu2jcg-o_O-inlineStyles_sc01dy" | |||
/> | |||
<a | |||
class="shared_ken7mo-o_O-resting_nelfll visited-no-recolor" | |||
class="shared_htyo3s-o_O-resting_nelfll visited-no-recolor" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a minor functional changes include in the new wonder-blocks-link
package so this is expected. This was necessary to move forward with wonder-blocks-link
in webapp.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @nishasy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know I'm going to sound like a broken record, but this is a lot of major dependency bumps. Worth doing a QE pass in a webapp ZND after you release this? I think Sarah has some bandwidth right now.
The major version number bumps are to communicate changes in the flow types. The only functional change is a minor change to link. There was an issue with link the last time we tried to update it where it wasn't respecting the surrounding font size. This version of link fixes that. |
Summary:
Now that wonder-blocks has been updated to use TS and the Flow types we're generating for those packages are working in webapp we need to update Perseus to use those same modules. This avoids shipping more code that we need and prevents subtle issues that can occur when using different version of the same packages via the same import name.
The major version number bumps in the wonder-blocks dependencies are to communicate changes in the flow types. The only functional change is a minor change to link. There was an issue with link the last time we tried to update it where it wasn't respecting the surrounding font size. This version of link fixes that.
Issue: FEI-5042
Test plan: