Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEI-5042: Update wonder-blocks dependencies #419

Merged
merged 3 commits into from
Mar 21, 2023
Merged

FEI-5042: Update wonder-blocks dependencies #419

merged 3 commits into from
Mar 21, 2023

Conversation

kevinbarabash
Copy link
Member

@kevinbarabash kevinbarabash commented Mar 20, 2023

Summary:

Now that wonder-blocks has been updated to use TS and the Flow types we're generating for those packages are working in webapp we need to update Perseus to use those same modules. This avoids shipping more code that we need and prevents subtle issues that can occur when using different version of the same packages via the same import name.

The major version number bumps in the wonder-blocks dependencies are to communicate changes in the flow types. The only functional change is a minor change to link. There was an issue with link the last time we tried to update it where it wasn't respecting the surrounding font size. This version of link fixes that.

Issue: FEI-5042

Test plan:

  • yarn flow
  • let CI run

@changeset-bot
Copy link

changeset-bot bot commented Mar 20, 2023

🦋 Changeset detected

Latest commit: 156633b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@khanacademy/perseus Minor
@khanacademy/perseus-editor Minor
@khanacademy/math-input Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kevinbarabash kevinbarabash self-assigned this Mar 20, 2023
@khan-actions-bot khan-actions-bot requested a review from a team March 20, 2023 19:35
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Mar 20, 2023

Gerald

Required Reviewers
  • @Khan/perseus for changes to yarn.lock, .changeset/clever-llamas-listen.md, .changeset/metal-days-behave.md, packages/math-input/package.json, packages/perseus/package.json, packages/perseus-editor/package.json, packages/perseus/src/widgets/__tests__/__snapshots__/video_test.jsx.snap

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@kevinbarabash kevinbarabash requested a review from a team March 20, 2023 19:35
@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2023

Size Change: 0 B

Total Size: 635 kB

ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.4 kB
packages/kmath/dist/es/index.js 4.18 kB
packages/math-input/dist/es/index.js 60.2 kB
packages/perseus-editor/dist/es/index.js 112 kB
packages/perseus-error/dist/es/index.js 825 B
packages/perseus-linter/dist/es/index.js 18.6 kB
packages/perseus/dist/es/index.js 385 kB
packages/pure-markdown/dist/es/index.js 3.74 kB
packages/simple-markdown/dist/es/index.js 12.9 kB

compressed-size-action

@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #419 (156633b) into main (7fcd40a) will increase coverage by 0.48%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #419      +/-   ##
==========================================
+ Coverage   65.50%   65.98%   +0.48%     
==========================================
  Files         481      487       +6     
  Lines      103961   107108    +3147     
  Branches     5620     7376    +1756     
==========================================
+ Hits        68095    70674    +2579     
- Misses      35866    36434     +568     

see 38 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fcd40a...156633b. Read the comment docs.

@@ -63,7 +63,7 @@ exports[`video widget should snapshot on mobile: first mobile render 1`] = `
class="default_xu2jcg-o_O-inlineStyles_sc01dy"
/>
<a
class="shared_ken7mo-o_O-resting_nelfll visited-no-recolor"
class="shared_htyo3s-o_O-resting_nelfll visited-no-recolor"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a minor functional changes include in the new wonder-blocks-link package so this is expected. This was necessary to move forward with wonder-blocks-link in webapp.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@handeyeco handeyeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know I'm going to sound like a broken record, but this is a lot of major dependency bumps. Worth doing a QE pass in a webapp ZND after you release this? I think Sarah has some bandwidth right now.

@kevinbarabash
Copy link
Member Author

I know I'm going to sound like a broken record, but this is a lot of major dependency bumps. Worth doing a QE pass in a webapp ZND after you release this? I think Sarah has some bandwidth right now.

The major version number bumps are to communicate changes in the flow types. The only functional change is a minor change to link. There was an issue with link the last time we tried to update it where it wasn't respecting the surrounding font size. This version of link fixes that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants