output ES5 code so that we can run the phantomjs tests in webapp #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for wonder-blocks ready! Built with commit a0565d8 |
Codecov Report
@@ Coverage Diff @@
## master #341 +/- ##
=======================================
Coverage 89.38% 89.38%
=======================================
Files 105 105
Lines 1479 1479
Branches 293 293
=======================================
Hits 1322 1322
Misses 135 135
Partials 22 22Continue to review full report at Codecov.
|
kevinbarabash
commented
Oct 12, 2018
| "@babel/preset-env", | ||
| { | ||
| targets: { | ||
| node: true, |
There was a problem hiding this comment.
This allows us to use async/await in our test code without having to load the regenerator runtime.
|
Which change in here actually changes the output to ES5? I don't see it. |
kevinbarabash
commented
Oct 12, 2018
somewhatabstract
approved these changes
Oct 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will also avoid having to update UglifyJS which also can't handle ES6 code. Upgrading both the phantomjs test runner and UglifyJS as part of the current build system aren't good uses of time given that we'll soon be replacing our current build system and test runner.