Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WB-558 Upgrade to the most recent version of Styleguidist #447

Merged
merged 3 commits into from Jul 11, 2019

Conversation

jandrade
Copy link
Member

Internal

  • Upgraded React Storybook to its latest version (9.1.11).
  • Updated code examples to match with RS requirements for this new version: Each example needed to import (require) all of its dependencies used in each snippet/block.

Test Plan

  1. Open https://deploy-preview-447--wonder-blocks.netlify.com/
  2. Check that all the examples are being rendered.

NOTE:

  • Added modules using require instead of import because this will be done in a separate ticket: WB-559.
  • In order to make import works correctly, we will need to update utils/gen-snapshot-tests.js to change the way we are parsing all the examples.

@jeresig
Copy link
Member

jeresig commented Jul 10, 2019

Deploy preview for wonder-blocks ready!

Built with commit 0a525d7

https://deploy-preview-447--wonder-blocks.netlify.com

@codecov
Copy link

codecov bot commented Jul 10, 2019

Codecov Report

Merging #447 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #447   +/-   ##
=======================================
  Coverage   94.85%   94.85%           
=======================================
  Files         112      112           
  Lines        1633     1633           
  Branches      325      325           
=======================================
  Hits         1549     1549           
  Misses         79       79           
  Partials        5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cadfc8...f5d841b. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 10, 2019

Codecov Report

Merging #447 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #447   +/-   ##
=======================================
  Coverage   94.85%   94.85%           
=======================================
  Files         112      112           
  Lines        1633     1633           
  Branches      325      325           
=======================================
  Hits         1549     1549           
  Misses         79       79           
  Partials        5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb0703e...0a525d7. Read the comment docs.

Copy link
Member

@jeresig jeresig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we have to be more explicit with our imports now, which seems like a good thing! Thank you for upgrading us!

Copy link
Member

@kevinbarabash kevinbarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I like that all requires are now explicit. Is this a storybook or styleguidist requirement?

Good call deferring moving to imports.

@kevinbarabash
Copy link
Member

I wonder how many of the security alerts will go away with this upgrade.

@jandrade jandrade merged commit e9f5060 into master Jul 11, 2019
@jandrade jandrade deleted the internal/styleguidist branch July 11, 2019 16:59
@jandrade
Copy link
Member Author

That was a Styleguidist requirement.

And now all the security alerts are gone 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants