New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WB-558 Upgrade to the most recent version of Styleguidist #447
Conversation
Deploy preview for wonder-blocks ready! Built with commit 0a525d7 |
Codecov Report
@@ Coverage Diff @@
## master #447 +/- ##
=======================================
Coverage 94.85% 94.85%
=======================================
Files 112 112
Lines 1633 1633
Branches 325 325
=======================================
Hits 1549 1549
Misses 79 79
Partials 5 5 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #447 +/- ##
=======================================
Coverage 94.85% 94.85%
=======================================
Files 112 112
Lines 1633 1633
Branches 325 325
=======================================
Hits 1549 1549
Misses 79 79
Partials 5 5 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we have to be more explicit with our imports now, which seems like a good thing! Thank you for upgrading us!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I like that all requires are now explicit. Is this a storybook or styleguidist requirement?
Good call deferring moving to import
s.
I wonder how many of the security alerts will go away with this upgrade. |
That was a Styleguidist requirement. And now all the security alerts are gone 🎉 |
Internal
require
) all of its dependencies used in each snippet/block.Test Plan
NOTE:
require
instead ofimport
because this will be done in a separate ticket: WB-559.import
works correctly, we will need to updateutils/gen-snapshot-tests.js
to change the way we are parsing all the examples.