Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#106, #103: add similar, recommendations, cast, crew tab for detail page #123

Merged
merged 4 commits into from Aug 21, 2022
Merged

#106, #103: add similar, recommendations, cast, crew tab for detail page #123

merged 4 commits into from Aug 21, 2022

Conversation

Khanhtran47
Copy link
Owner

@Khanhtran47 Khanhtran47 commented Aug 21, 2022 •
edited

add tabs for detail page:

  • similar
  • recommendations
  • cast
  • crew

change:

  • load data needed in index file of id of movie and tv
  • check data exist for some lists
  • style of tab component

@Khanhtran47 Khanhtran47 self-assigned this Aug 21, 2022
@vercel
Copy link

vercel bot commented Aug 21, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
remix-movie ✅ Ready (Inspect) Visit Preview Aug 21, 2022 at 1:51PM (UTC)

@Khanhtran47 Khanhtran47 linked an issue Aug 21, 2022 that may be closed by this pull request
Detail page: similar tab, recommendation tab #106
Closed
@Khanhtran47 Khanhtran47 marked this pull request as draft August 21, 2022 11:53
@Khanhtran47 Khanhtran47 removed the request for review from ctuanle August 21, 2022 11:53
@Khanhtran47 Khanhtran47 changed the title fea#106: add similar, recommendations tab for detail page featue#106, #103: add similar, recommendations, cast, crew tab for detail page Aug 21, 2022
@Khanhtran47 Khanhtran47 changed the title featue#106, #103: add similar, recommendations, cast, crew tab for detail page #106, #103: add similar, recommendations, cast, crew tab for detail page Aug 21, 2022
@Khanhtran47 Khanhtran47 linked an issue Aug 21, 2022 that may be closed by this pull request
Detail page: Cast and Crew tab #103
Closed
@Khanhtran47 Khanhtran47 marked this pull request as ready for review August 21, 2022 13:59
@Khanhtran47 Khanhtran47 mentioned this pull request Aug 21, 2022
Closed
Khanhtran47
Khanhtran47 commented Aug 21, 2022
View reviewed changes
app/routes/movies/$movieId/index.tsx
similar,
recommendations,
topBilledCast: credits && credits.cast && credits.cast.slice(0, 9),
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctuanle ở đây mình có thể return về data mình cần được nơi m 🤟

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Khanhtran47 return gì k hiểu nơi, chỗ lấy data từ routes parent á ?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctuanle kiểu cái m nói chỉ lấy data cần thiết như bên graphQL ý, bên remix cái return ở chỗ loader, mình có thể return cái gì cũng đc

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctuanle m đọc cái bài ni cho dễ hiểu hơn 😅
https://sergiodxa.com/articles/load-only-the-data-you-need-in-remix

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Khanhtran47 t nhớ chỗ loader đúng là mình return cái gì cũng được thật 😅

ctuanle
ctuanle approved these changes Aug 21, 2022
View reviewed changes
Copy link
Collaborator

@ctuanle ctuanle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

< good job >

    \   ^__^
     \  (oo)\_______
        (__)\       )\/\
            ||----w |
            ||     ||

@Khanhtran47 Khanhtran47 merged commit b7e18f6 into develop Aug 21, 2022
@Khanhtran47 Khanhtran47 deleted the feature/106 branch August 31, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctuanle ctuanle ctuanle approved these changes

Assignees

@Khanhtran47 Khanhtran47

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Detail page: similar tab, recommendation tab Detail page: Cast and Crew tab
2 participants
@Khanhtran47 @ctuanle