Week4 #9
Week4 #9
Conversation
| @@ -14,10 +14,120 @@ | |||
|
|
|||
| package com.google.sps; | |||
|
|
|||
| import java.util.Collection; | |||
| import java.util.*; | |||
There was a problem hiding this comment.
Let's avoid folded imports
There was a problem hiding this comment.
Noted, I have changed it to
import java.util.HashSet;
import java.util.Iterator;
import java.util.ArrayList;
import java.util.Collections;
import java.util.Collection;
|
|
||
| /* | ||
| public final class FindMeetingQuery { | ||
| public Collection<TimeRange> query(Collection<Event> events, MeetingRequest request) { |
There was a problem hiding this comment.
Remove stray comments
walkthroughs/week-4-tdd/project/src/main/java/com/google/sps/FindMeetingQuery.java
Outdated
Show resolved
Hide resolved
| public ArrayList<TimeRange> filterTimes(Collection<Event> events, HashSet<String> attendees) { | ||
| ArrayList<TimeRange> times = new ArrayList<TimeRange>(); | ||
| for (Event event: events) { | ||
| HashSet<String> curr_attendees = new HashSet<String>(); |
There was a problem hiding this comment.
Use camelCase naming to keep it similar to rest of the variable names
There was a problem hiding this comment.
okay, changed curr_attendees to currAttendees
| } | ||
| }*/ | ||
|
|
||
|
|
|
|
||
|
|
||
| public final class FindMeetingQuery { | ||
| public boolean hasMatch(HashSet<String> first, HashSet<String> second) { |
There was a problem hiding this comment.
first and second as argument names sound unclear as to what they hold
There was a problem hiding this comment.
Okay, what should I change it to? I saw on Event.java file that they used a and b for this kind of compare function. Should I change it to a and b?
|
|
||
| public final class FindMeetingQuery { | ||
| /** | ||
| Check if any of the string that appear in stringSet appear in otherSet |
There was a problem hiding this comment.
Move comment to same line as opening and closing comment of the comment
Complete requirement for week 4