Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added destructor function to clean up the global memstack #21

Merged
merged 4 commits into from
Jun 13, 2023
Merged

Conversation

Khhs167
Copy link
Owner

@Khhs167 Khhs167 commented Jun 13, 2023

As requested in #17, the code should now clean up the global memstack before exit.

Currently this only compiles for GCC, so I think some research is due.

@Khhs167
Copy link
Owner Author

Khhs167 commented Jun 13, 2023

It should now compile on all compilers that support C preproc macros.

@Khhs167 Khhs167 requested a review from hrszpuk June 13, 2023 07:02
@Khhs167 Khhs167 linked an issue Jun 13, 2023 that may be closed by this pull request
Copy link
Collaborator

@hrszpuk hrszpuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (small typo, can be ignored tbh)

src/memstack.c Outdated Show resolved Hide resolved
@Khhs167 Khhs167 merged commit 8488178 into master Jun 13, 2023
1 check passed
@Khhs167 Khhs167 deleted the cleaner branch June 13, 2023 07:30
@Khhs167 Khhs167 mentioned this pull request Jun 13, 2023
@Khhs167 Khhs167 added this to the Next Release(1.3.0/1.2.1) milestone Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

free the global stack at exit
3 participants