Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid reference files #1

Closed
jterrace opened this issue Jul 11, 2012 · 4 comments
Closed

Invalid reference files #1

jterrace opened this issue Jul 11, 2012 · 4 comments

Comments

@jterrace
Copy link
Contributor

The following list of files have indices that go beyond the length of a source. Bug 528 from the bugzilla reported last September.

  • StandardDataSets/collada/library_cameras/camera/_reference/_reference_optics_orthographic_zfar_znear/_reference_optics_orthographic_zfar_znear.dae
  • StandardDataSets/collada/library_cameras/camera/_reference/_reference_optics_perspective_zfar_znear/_reference_optics_perspective_zfar_znear.dae
  • StandardDataSets/collada/library_cameras/camera/id/id_dash/id_dash.dae
  • StandardDataSets/collada/library_cameras/camera/id/id_period/id_period.dae
  • StandardDataSets/collada/library_cameras/camera/id/id_underscore/id_underscore.dae
  • StandardDataSets/collada/library_cameras/camera/optics/orthographic/optics_orthographic_xmag/optics_orthographic_xmag.dae
  • StandardDataSets/collada/library_cameras/camera/optics/orthographic/optics_orthographic_xmag_aspect_ratio/optics_orthographic_xmag_aspect_ratio.dae
  • StandardDataSets/collada/library_cameras/camera/optics/orthographic/optics_orthographic_xmag_ymag/optics_orthographic_xmag_ymag.dae
  • StandardDataSets/collada/library_cameras/camera/optics/orthographic/optics_orthographic_ymag/optics_orthographic_ymag.dae
  • StandardDataSets/collada/library_cameras/camera/optics/orthographic/optics_orthographic_ymag_aspect_ratio/optics_orthographic_ymag_aspect_ratio.dae
  • StandardDataSets/collada/library_cameras/camera/optics/orthographic/optics_orthographic_zfar/optics_orthographic_zfar.dae
  • StandardDataSets/collada/library_cameras/camera/optics/orthographic/optics_orthographic_znear/optics_orthographic_znear.dae
  • StandardDataSets/collada/library_cameras/camera/optics/perspective/optics_perspective_xfov/optics_perspective_xfov.dae
  • StandardDataSets/collada/library_cameras/camera/optics/perspective/optics_perspective_xfov_aspect_ratio/optics_perspective_xfov_aspect_ratio.dae
  • StandardDataSets/collada/library_cameras/camera/optics/perspective/optics_perspective_xfov_yfov/optics_perspective_xfov_yfov.dae
  • StandardDataSets/collada/library_cameras/camera/optics/perspective/optics_perspective_yfov/optics_perspective_yfov.dae
  • StandardDataSets/collada/library_cameras/camera/optics/perspective/optics_perspective_yfov_aspect_ratio/optics_perspective_yfov_aspect_ratio.dae
  • StandardDataSets/collada/library_cameras/camera/optics/perspective/optics_perspective_zfar/optics_perspective_zfar.dae
  • StandardDataSets/collada/library_cameras/camera/optics/perspective/optics_perspective_znear/optics_perspective_znear.dae
@fabrobinet
Copy link
Contributor

Ok, I had another report about this (without github issue unfortunately).

Not sure yet if there is a to "fix" these file by making a acceptable change by adding dummy data, or if we should just get rid of them. If we remove them we need to take care of the places where they are referenced...

@fabrobinet
Copy link
Contributor

sorry the few typos :) above, I meant, Not sure yet if there is a way to "fix" them...

@jterrace
Copy link
Contributor Author

I think the reason it slipped by is because the data isn't actually instabtiated. Theyre just used for testing properties of cameras. I think it was probably just a mistake once that got copied and pasted several times. I think the right thing is just to add some dummy data so the files aren't invalid. I might even have modified files I made for that, so if that sounds good, I can submit a pull request.

@fabrobinet
Copy link
Contributor

Yes, that's what I would have tried too. I would be very interested in the pull request you suggest. Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants