Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install *.pc below CMAKE_INSTALL_DATADIR #217

Open
anbe42 opened this issue Feb 11, 2023 · 3 comments
Open

install *.pc below CMAKE_INSTALL_DATADIR #217

anbe42 opened this issue Feb 11, 2023 · 3 comments

Comments

@anbe42
Copy link

anbe42 commented Feb 11, 2023

Since these headers are architecture independent, please install the pkgconfig file in the architecture independent location below CMAKE_INSTALL_DATADIR (effectively /usr/share/pkgconfig/) like it is already done with the *.cmake files instead of the architecture dependent location below CMAKE_INSTALL_LIBDIR (on Debian/amd64 /usr/lib/x86_64-linux-gnu/pkgconfig/)

May affect the clhpp headers, too.

@Kerilk
Copy link
Contributor

Kerilk commented Feb 13, 2023

@anbe42 Thanks for the feeback, I'll prepare a series of pull request to implement this.

@Kerilk
Copy link
Contributor

Kerilk commented Feb 13, 2023

@anbe42 PRs are ready. I do have a couple of questions for you:

  • We could either do a fix release, or wait for IWOCL (mid April) to release those changes. Any preference?
  • What would you advise for the C++ headers? Should we add their own pkg-config file that would depend on the OpenCL headers one? Until now we considered they would be installed alongside each other, but given the direction we took by splitting loader and headers, maybe we should go all the way.

Thanks

@Kerilk
Copy link
Contributor

Kerilk commented Feb 22, 2023

@anbe42 We've pushed the various fixes. We also added a .pc file to the C++ headers. please tell me if this looks good to you or if further actions should be taken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants