Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken docker link in "Building the OpenXR Specification" page #476

Closed
dgough opened this issue May 1, 2024 · 4 comments
Closed

Broken docker link in "Building the OpenXR Specification" page #476

dgough opened this issue May 1, 2024 · 4 comments
Labels
synced to gitlab Synchronized to OpenXR internal GitLab

Comments

@dgough
Copy link

dgough commented May 1, 2024

The URL to the docker file in Building the OpenXR Specification is broken. I assume it is supposed to be:

https://github.com/KhronosGroup/DockerContainers/blob/main/openxr-sdk.Dockerfile

Also, the instructions mention open-in-docker.sh, but I don't see that anywhere.

@rpavlik
Copy link
Contributor

rpavlik commented May 2, 2024

Good catch, yes we did rename that file a while back. (the one you linked is actually for SDK build, not for the spec build.) The images are pushed to docker-hub however.

Since those docs (and the container) are intended for spec build, the open-in-docker script is only in the docs repo (as well as the private Khronos monorepo): https://github.com/KhronosGroup/OpenXR-Docs/blob/main/open-in-docker.sh

Since we do have the loader doc in this repo, I suppose it might make sense to ship it in this one too, I'll adjust that for the next release.

@rpavlik-bot
Copy link
Collaborator

An issue (number 2283) has been filed to correspond to this issue in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#2283 ), to facilitate working group processes.

This GitHub issue will continue to be the main site of discussion.

@rpavlik-bot rpavlik-bot added the synced to gitlab Synchronized to OpenXR internal GitLab label May 2, 2024
@rpavlik
Copy link
Contributor

rpavlik commented May 2, 2024

OK, I have an internal MR to fix the docs and ship the script in this repo too, I anticipate it will be merged for the next release.

@rpavlik
Copy link
Contributor

rpavlik commented May 25, 2024

Fixed in 1.1.37, thanks for the report!

@rpavlik rpavlik closed this as completed May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
synced to gitlab Synchronized to OpenXR internal GitLab
Projects
None yet
Development

No branches or pull requests

3 participants