Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it valid to have duplicate Execution Modes #150

Open
sjfricke opened this issue Jun 23, 2022 · 1 comment
Open

Is it valid to have duplicate Execution Modes #150

sjfricke opened this issue Jun 23, 2022 · 1 comment

Comments

@sjfricke
Copy link

sjfricke commented Jun 23, 2022

Came across this while writing validation for KhronosGroup/SPIRV-Tools#4828

I assume the following is not actually allowed, but spirv-val doesn't check it and nothing in spec to refer to it being illegal.

OpExecutionMode %entrypoint LocalSize 1 2 1
OpExecutionMode %entrypoint LocalSize 1 1 2
@raunraun
Copy link
Contributor

WG would like to disallow duplicate ExecutionModes except in the case where the ExecutionMode describes what happens if there is a duplicate.

For your example, that would be illegal.

FloatControls does allow duplicates (I think this is the only exception) and would need clearer documentation.

SPIR-V 1.6rev2 disallowed duplicate decorations. I'm proposing the same rule apply to ExecutionModes: https://www.khronos.org/registry/SPIR-V/specs/unified1/SPIRV.html#_decoration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants