Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code massage for the test fixture class #22

Closed
antiagainst opened this issue Nov 20, 2015 · 2 comments
Closed

Code massage for the test fixture class #22

antiagainst opened this issue Nov 20, 2015 · 2 comments

Comments

@antiagainst
Copy link
Contributor

The name of TextToBinaryTest[Base] is outdated; we actually have roundtrip test methods inside it. I'd like to change it to RoundTripTest[Base]. And also, rename the methods inside it to something like {Encode|Decode}...{Succeeded|Failed}....

Opinions?

@dneto0
Copy link
Collaborator

dneto0 commented Nov 20, 2015

I like the CompiledInstructions name. That's very clear.
I don't like the "Encode" because, especially in a round trip sense, it's not clear what the originating format is, text or binary.
I'd rather not make this change.

@antiagainst
Copy link
Contributor Author

I don't care about the naming that much; I just want to make sure they are consistent (like changing the Encode to Compiled). But since there are objections, I'll not do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants