Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpAtomicCompareExchange tests #47

Closed
jlegg0 opened this issue Jun 21, 2017 · 4 comments
Closed

Add OpAtomicCompareExchange tests #47

jlegg0 opened this issue Jun 21, 2017 · 4 comments

Comments

@jlegg0
Copy link

jlegg0 commented Jun 21, 2017

It would be nice if there were Vulkan tests for the OpAtomicCompareExchange and OpAtomicCompareExchangeWeak instructions. The other atomic instructions are tested on images in dEQP-VK.image.atomic_operations.

@alegal-arm
Copy link
Contributor

@jlegg0, have you looked into dEQP-VK.spirv_assembly.instruction.compute.opatomic* tests?
They already cover OpAtomicCompareExchange.

OpAtomicCompareExchangeWeak requires Kernel capability which is not exposed in Vulkan.

@jlegg0
Copy link
Author

jlegg0 commented Jun 23, 2017

On Wed, 2017-06-21 at 16:12 -0700, Alexander Galazin wrote:

@jlegg0, have you looked into dEQP-
VK.spirv_assembly.instruction.compute.opatomic* tests?

These tests operate on BufferBlock structures. I'ld specifically like a
test for OpAtomicCompareExchange on images, as that didn't work in
Mesa.

They already cover OpAtomicCompareExchange.

True. Sorry, I should have been more specific in my original request.

OpAtomicCompareExchangeWeak requires Kernel capability which is not
exposed in Vulkan.

I see. Fair enough.

@alegal-arm
Copy link
Contributor

Thanks for the report. This is tracked internally. If you are able to develop and contribute such test we would be glad to review and accept it.

@alegal-arm
Copy link
Contributor

Tests for OpAtomicCompareExchange on images added in f669677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants