Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vk.xml path inconsistency in CMakeLists.txt #793

Closed
timo-suoranta-varjo opened this issue Oct 21, 2020 · 2 comments · Fixed by #796
Closed

vk.xml path inconsistency in CMakeLists.txt #793

timo-suoranta-varjo opened this issue Oct 21, 2020 · 2 comments · Fixed by #796

Comments

@timo-suoranta-varjo
Copy link

timo-suoranta-varjo commented Oct 21, 2020

In Vulkan-Hpp/CMakeLists.txt, path to vk.xml in has some inconsistency.
VulkanRegistry_DIR cannot point to Vulkan-Docs, because inside it vk.xml is inside xml directory.
Meanwhile, Vulkan-Hpp CMakeLists.txt expects vk.xml to be found from directory called registry.

One possible solution is to move Vulkan-Headers/registry/vk.xml to Vulkan-Headers/registry/xml/vk.xml.

IMHO it is not ideal that Vulkan-Headers keeps copy of registry from Vulkan-Docs. It would be better to simply use files from Vulkan-Docs directly.

@asuessenbach
Copy link
Contributor

VulkanRegistry_DIR is supposed to point to Vulkan-Headers/registry, not to Vulkan-Docs
That said, we're currently using it wrong, expecting it would point to Vulkan-Headers, I will adjust it accordingly!

@timo-suoranta-varjo
Copy link
Author

Presumably then VulkanRegistry_DIR can also point to Vulkan-Docs/xml?
Why Vulkan-Headers is used in the middle at all, why not use Vulkan-Docs directly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants