Skip to content
This repository has been archived by the owner on Jul 19, 2018. It is now read-only.

windowsRuntimeInstaller Uninstaller succeds (retcode == 0) when ConfigureRT fails #2223

Open
ghost opened this issue Nov 21, 2017 · 3 comments
Assignees
Milestone

Comments

@ghost
Copy link

ghost commented Nov 21, 2017

As the last step of VulkanRT uninstallation, ConfigureRT.exe is run to elect newest loader /&vulkaninfo and place them as vulkan-1.dll / vulkaninfo.exe in %SYSTEM% directory.

It seems when ConfigureRT fails, it seems the error is not passed via uninstaller, which exists with code 0 ignoring the failure.

For example, I have installed 3 RTs of different version and removed N-1 (N == newest) vulkan-1-x-x-x-x.dll.
When running the uninstaller of N (newest), ConfigureRT fails with error 220 due to vulkaninfo & vulkan-1.dll version mismatch (N-1 != N-2). It seems no loader is elected, however this error is not signalized in uninstaller, which silently passes and returns retcode 0.

@lenny-lunarg
Copy link
Contributor

We definitely agree that this change should be made, and it'll actually happen soon since I'm already working on it. In the current logic, if ConfigureRT fails, the NSIS installer will do its best to do the same copying on its own, and forgets to check for errors if the NSIS installer fails. We're going to stop the NSIS installer from doing anything except reporting an error when ConfigureRT fails. We're also going to improve the logging when ConfigureRT can't modify vulkan-1.dll (which seems to be the most common failure).

I'll keep this issue updated when we actually make the change.

@mark-lunarg
Copy link
Collaborator

@lenny-lunarg, any updates?

@lenny-lunarg
Copy link
Contributor

The status of this issue is that ConfigureRT.exe is going to be removed entirely, shortly. As a side effect, that will resolve this issue. I'll close this issue when I actually make the change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants