Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hello_triangle sample should avoid referencing a retired swapchain #1015 #1019

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

hello_triangle sample should avoid referencing a retired swapchain #1015 #1019

wants to merge 2 commits into from

Conversation

yaman-lunarg
Copy link

Description

By obtaining the image_count prior to the retirement of old_swapchain, Android warning is prevented.

Fixes #1015

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

  • I have tested the sample on at least one compliant Vulkan implementation
  • If the sample is vendor-specific, I have tagged it appropriately
  • I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
  • Any dependent assets have been merged and published in downstream modules
  • For new samples, I have added a paragraph with a summary to the appropriate chapter in the readme of the folder that the sample belongs to e.g. api samples readme
  • For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
  • For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

@CLAassistant
Copy link

CLAassistant commented Apr 11, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@asuessenbach
Copy link
Contributor

As I don't have an Android environment to test, I can't tell if this change is valid. But it looks a bit strange...
If it actually is an issue, could you please adjust hpp_hello_triangle accordingly?

@marty-johnson59
Copy link
Contributor

HI @yaman-lunarg, this is still labeled "draft". Any thoughts on next steps? Thanks

@bradgrantham-lunarg
Copy link

bradgrantham-lunarg commented Jul 3, 2024 •
edited
Loading

Yaman no longer is available at that login. We probably won't carry forward this PR, we don't have any resource to handle the long to-do list.

We noted this failure on Android in logcat:

Running some vulkan samples, for example Hello Triangle on android with gfxr enabled a warning is issued:

02-27 19:12:17.625 31072 31130 W vulkan : getting images for non-active swapchain 0xb400007a8dd3ef70; only dequeued image handles are valid

It comes from here: https://android.googlesource.com/platform/frameworks/native/+/android-8.1.0_r9/vulkan/libvulkan/swapchain.cpp#1173

I've gotten this on Pixel 6, to reproduce just run Vulkan Samples and choose the Hello Triangle sample, with gfxr enabled

In reply to @asuessenbach the current code is incorrect under the spec (but there may not be a VUID). Passing old_swapchain to CreateSwapchainKHR makes old_swapchain retired, and images cannot then be acquired from that swapchain. This PR makes sure the images are acquired before the swapchain is retired.

Retired Swapchain
A swapchain that has been used as the oldSwapchain parameter to vkCreateSwapchainKHR. Images cannot be acquired from a retired swapchain, however images that were acquired (but not presented) before the swapchain was retired can be presented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hello_triangle sample references a retired swapchain
5 participants
@yaman-lunarg @CLAassistant @asuessenbach @marty-johnson59 @bradgrantham-lunarg