Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mock icd: Add support for vkGetPhysicalDeviceFeatures2KHR pNext extension queries #4

Closed
karl-lunarg opened this issue May 14, 2018 · 2 comments
Closed

Mock icd: Add support for vkGetPhysicalDeviceFeatures2KHR pNext extension queries #4

karl-lunarg opened this issue May 14, 2018 · 2 comments
Assignees
@tobine
Labels
enhancement New feature or request MockICD

Comments

@karl-lunarg
Copy link
Contributor

Issue by jzulauf-lunarg (MIGRATED)
Friday Jan 26, 2018 at 22:40 GMT
Originally opened as KhronosGroup/Vulkan-LoaderAndValidationLayers#2374

The mock_icd needs to report valid limit/feature information for all extensions it reported as supported. Currently mock_icd ignores the pNext chain for vkGetPhysicalDeviceFeatures2KHR where the extension features are queried.

However, when validation support is added for an extension, the features and limits need to be reported back with valid (for example guaranteed minimums given in the spec) values in order for validation to have proper bounds/feature checks and for validation testing to function correctly.
@karl-lunarg karl-lunarg added the enhancement New feature or request label May 14, 2018
@karl-lunarg karl-lunarg mentioned this issue May 14, 2018
Closed
arunsivaramanneo referenced this issue Jan 23, 2019
@lunarpapillo
issue 126: fix vulkaninfo segfault on 1.0 devices
0140238 
We didn't quite get the check on whether a format can be legally
queried on a particular GPU quite right.  We were checking against
the instance version only.  We need to check agains the driver's
supported API version as well.
@KarenGhavam-lunarG KarenGhavam-lunarG changed the title icd: Add support for vkGetPhysicalDeviceFeatures2KHR pNext extension queries Mock icd: Add support for vkGetPhysicalDeviceFeatures2KHR pNext extension queries Dec 20, 2019
@spencer-lunarg
Copy link
Contributor

spencer-lunarg commented Feb 16, 2023 •
edited
Loading

closing this because Profiles is able to handle all features

@spencer-lunarg
Copy link
Contributor

spencer-lunarg commented Feb 16, 2023 •
edited
Loading

If MockICD does need to support the Feature bits in the future, something could be generated to set all VkPhysicalDevice*Features structs' VkBool32 to true, but for now I see no use case to do this in MockICD and not profiles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tobine tobine

Labels
enhancement New feature or request MockICD
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tobine @karl-lunarg @charles-lunarg @spencer-lunarg