Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vkcubepp + Wayland fails with Clang due to -Werror #532

Closed
jbeich opened this issue Jun 15, 2021 · 2 comments
Closed

vkcubepp + Wayland fails with Clang due to -Werror #532

jbeich opened this issue Jun 15, 2021 · 2 comments
Assignees
Labels
bug Something isn't working vkcube

Comments

@jbeich
Copy link
Contributor

jbeich commented Jun 15, 2021

Regressed by 0143cbe + ac93933 (CC @mstoeckl). From error log:

$ export CC=clang12 CXX=clang++12
$ cmake -DCUBE_WSI_SELECTION=WAYLAND -G Ninja -B /tmp/vktools_build
$ cmake --build /tmp/vktools_build
FAILED: cube/CMakeFiles/vkcubepp.dir/cube.cpp.o
clang++12 -DVK_ENABLE_BETA_EXTENSIONS -DVK_USE_PLATFORM_WAYLAND_KHR -Icube -Icube -Icube/.. -isystem /usr/local/include -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -fno-strict-aliasing -fno-builtin-memcmp -Werror -std=c++11 -fno-rtti -fvisibility=hidden -MD -MT cube/CMakeFiles/vkcubepp.dir/cube.cpp.o -MF cube/CMakeFiles/vkcubepp.dir/cube.cpp.o.d -o cube/CMakeFiles/vkcubepp.dir/cube.cpp.o -c cube/cube.cpp
cube/cube.cpp:416:40: error: unused variable 'shell_surface_listener' [-Werror,-Wunused-const-variable]
static const wl_shell_surface_listener shell_surface_listener = {handle_ping, handle_configure, handle_popup_done};
                                       ^
1 error generated.
@jbeich jbeich changed the title vkcube -DVK_USE_PLATFORM_WAYLAND_KHR fails to build with Clang vkcubepp + Wayland fails with Clang due to -Werror Jun 15, 2021
@jeremyk-lunarg jeremyk-lunarg added bug Something isn't working vkcube labels Jun 15, 2021
@TonyBarbour
Copy link
Contributor

Fixed in #538

@jbeich
Copy link
Contributor Author

jbeich commented Jun 17, 2021

I can still reproduce:

cube/cube.cpp:408:13: error: unused function 'handle_ping' [-Werror,-Wunused-function]
static void handle_ping(void *data, wl_shell_surface *shell_surface, uint32_t serial) {
            ^
cube/cube.cpp:412:13: error: unused function 'handle_configure' [-Werror,-Wunused-function]
static void handle_configure(void *data, wl_shell_surface *shell_surface, uint32_t edges, int32_t width, int32_t height) {}
            ^
cube/cube.cpp:414:13: error: unused function 'handle_popup_done' [-Werror,-Wunused-function]
static void handle_popup_done(void *data, wl_shell_surface *shell_surface) {}
            ^
3 errors generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vkcube
Projects
None yet
Development

No branches or pull requests

3 participants