Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant Vulkan API version checks #1553

Closed
sfricke-samsung opened this issue Feb 14, 2020 · 0 comments · Fixed by #1565
Closed

Remove redundant Vulkan API version checks #1553

sfricke-samsung opened this issue Feb 14, 2020 · 0 comments · Fixed by #1565
Milestone

Comments

@sfricke-samsung
Copy link
Contributor

As discussed in #1541

The code

for (auto promoted_ext : V_1_1_promoted_device_apis) {
    info = get_info(promoted_ext);
    if (info.state) this->*(info.state) = kEnabledByApiLevel;
}

Adds all core extensions when a version is detected.

For example there is no need to do

if ((api_version >= VK_API_VERSION_1_1) || (device_extensions.vk_khr_maintenance1)) {
   // VUID-x
}

Since the 1.1 check is redundant here.

This issue is to track the removal of other redundant checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants