build failure on Fedora 38

[zmike]

Trying to build from d1bb20e on F38 and I get a ton of errors like:

[3/86] Building CXX object layers/CMakeFiles/VkLayer_khronos_validation.dir/external/vma/vma.cpp.o
FAILED: layers/CMakeFiles/VkLayer_khronos_validation.dir/external/vma/vma.cpp.o 
/usr/lib64/ccache/c++ -DUSE_ROBIN_HOOD_HASHING -DVK_ENABLE_BETA_EXTENSIONS -DVK_USE_PLATFORM_WAYLAND_KHR -DVK_USE_PLATFORM_XCB_KHR -DVK_USE_PLATFORM_XLIB_KHR -DVK_USE_PLATFORM_XLIB_XRANDR_EXT -DVkLayer_khronos_validation_EXPORTS -DXXH_NO_LONG_LONG -I/home/zmike/src/Vulkan-ValidationLayers/layers/. -isystem /home/zmike/src/Vulkan-ValidationLayers/layers/external -isystem /home/zmike/src/Vulkan-ValidationLayers/external/Debug/robin-hood-hashing/build/install/include -isystem /home/zmike/src/Vulkan-ValidationLayers/external/Debug/SPIRV-Headers/build/install/include -isystem /home/zmike/src/Vulkan-ValidationLayers/external/Debug/SPIRV-Tools/build/install/include -isystem /home/zmike/src/Vulkan-ValidationLayers/external/Debug/Vulkan-Headers/build/install/include -O3 -DNDEBUG -std=c++17 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -Wall -Wextra -Wpointer-arith -Wno-unused-parameter -MD -MT layers/CMakeFiles/VkLayer_khronos_validation.dir/external/vma/vma.cpp.o -MF layers/CMakeFiles/VkLayer_khronos_validation.dir/external/vma/vma.cpp.o.d -o layers/CMakeFiles/VkLayer_khronos_validation.dir/external/vma/vma.cpp.o -c /home/zmike/src/Vulkan-ValidationLayers/layers/external/vma/vma.cpp
In file included from /home/zmike/src/Vulkan-ValidationLayers/layers/external/vma/vma.h:39,
                 from /home/zmike/src/Vulkan-ValidationLayers/layers/external/vma/vma.cpp:22:
/home/zmike/src/Vulkan-ValidationLayers/layers/external/vma/vk_mem_alloc.h: In function ‘void VmaUint32ToStr(char*, size_t, uint32_t)’:
/home/zmike/src/Vulkan-ValidationLayers/layers/external/vma/vk_mem_alloc.h:2859:9: error: ‘snprintf’ was not declared in this scope
 2859 |         snprintf(outStr, strLen, "%u", static_cast<unsigned int>(num));
      |         ^~~~~~~~
/home/zmike/src/Vulkan-ValidationLayers/layers/external/vma/vk_mem_alloc.h:2685:1: note: ‘snprintf’ is defined in header ‘<cstdio>’; did you forget to ‘#include <cstdio>’?
 2684 |     #include <mutex>
  +++ |+#include <cstdio>
 2685 | #else
/home/zmike/src/Vulkan-ValidationLayers/layers/external/vma/vk_mem_alloc.h: In function ‘void VmaUint64ToStr(char*, size_t, uint64_t)’:
/home/zmike/src/Vulkan-ValidationLayers/layers/external/vma/vk_mem_alloc.h:2863:9: error: ‘snprintf’ was not declared in this scope
 2863 |         snprintf(outStr, strLen, "%llu", static_cast<unsigned long long>(num));
      |         ^~~~~~~~
/home/zmike/src/Vulkan-ValidationLayers/layers/external/vma/vk_mem_alloc.h:2863:9: note: ‘snprintf’ is defined in header ‘<cstdio>’; did you forget to ‘#include <cstdio>’?
/home/zmike/src/Vulkan-ValidationLayers/layers/external/vma/vk_mem_alloc.h: In function ‘void VmaPtrToStr(char*, size_t, const void*)’:
/home/zmike/src/Vulkan-ValidationLayers/layers/external/vma/vk_mem_alloc.h:2867:9: error: ‘snprintf’ was not declared in this scope
 2867 |         snprintf(outStr, strLen, "%p", ptr);
      |         ^~~~~~~~
/home/zmike/src/Vulkan-ValidationLayers/layers/external/vma/vk_mem_alloc.h:2867:9: note: ‘snprintf’ is defined in header ‘<cstdio>’; did you forget to ‘#include <cstdio>’?
[16/86] Building CXX object layers/CMakeFiles/VkLayer_khronos_validation.dir/stateless/cmd_buffer_dynamic_sl_validation.cpp.o
FAILED: layers/CMakeFiles/VkLayer_khronos_validation.dir/stateless/cmd_buffer_dynamic_sl_validation.cpp.o 
/usr/lib64/ccache/c++ -DUSE_ROBIN_HOOD_HASHING -DVK_ENABLE_BETA_EXTENSIONS -DVK_USE_PLATFORM_WAYLAND_KHR -DVK_USE_PLATFORM_XCB_KHR -DVK_USE_PLATFORM_XLIB_KHR -DVK_USE_PLATFORM_XLIB_XRANDR_EXT -DVkLayer_khronos_validation_EXPORTS -DXXH_NO_LONG_LONG -I/home/zmike/src/Vulkan-ValidationLayers/layers/. -isystem /home/zmike/src/Vulkan-ValidationLayers/layers/external -isystem /home/zmike/src/Vulkan-ValidationLayers/external/Debug/robin-hood-hashing/build/install/include -isystem /home/zmike/src/Vulkan-ValidationLayers/external/Debug/SPIRV-Headers/build/install/include -isystem /home/zmike/src/Vulkan-ValidationLayers/external/Debug/SPIRV-Tools/build/install/include -isystem /home/zmike/src/Vulkan-ValidationLayers/external/Debug/Vulkan-Headers/build/install/include -O3 -DNDEBUG -std=c++17 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -Wall -Wextra -Wpointer-arith -Wno-unused-parameter -MD -MT layers/CMakeFiles/VkLayer_khronos_validation.dir/stateless/cmd_buffer_dynamic_sl_validation.cpp.o -MF layers/CMakeFiles/VkLayer_khronos_validation.dir/stateless/cmd_buffer_dynamic_sl_validation.cpp.o.d -o layers/CMakeFiles/VkLayer_khronos_validation.dir/stateless/cmd_buffer_dynamic_sl_validation.cpp.o -c /home/zmike/src/Vulkan-ValidationLayers/layers/stateless/cmd_buffer_dynamic_sl_validation.cpp
In file included from /home/zmike/src/Vulkan-ValidationLayers/layers/./stateless/stateless_validation.h:21,
                 from /home/zmike/src/Vulkan-ValidationLayers/layers/stateless/cmd_buffer_dynamic_sl_validation.cpp:19:
/home/zmike/src/Vulkan-ValidationLayers/layers/./stateless/parameter_name.h: In member function ‘bool ParameterName::IsValid()’:
/home/zmike/src/Vulkan-ValidationLayers/layers/./stateless/parameter_name.h:110:9: error: ‘uint32_t’ was not declared in this scope
  110 |         uint32_t count = 0;
      |         ^~~~~~~~
/home/zmike/src/Vulkan-ValidationLayers/layers/./stateless/parameter_name.h:25:1: note: ‘uint32_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’?
   24 | #include <cstring>
  +++ |+#include <cstdint>
   25 | 
/home/zmike/src/Vulkan-ValidationLayers/layers/./stateless/parameter_name.h:117:15: error: ‘count’ was not declared in this scope
  117 |             ++count;
      |               ^~~~~
/home/zmike/src/Vulkan-ValidationLayers/layers/./stateless/parameter_name.h:121:17: error: ‘count’ was not declared in this scope
  121 |         return (count == num_indices_);
      |                 ^~~~~
[17/86] Building CXX object layers/CMakeFiles/VkLayer_khronos_validation.dir/stateless/buffer_sl_validation.cpp.o
FAILED: layers/CMakeFiles/VkLayer_khronos_validation.dir/stateless/buffer_sl_validation.cpp.o 
/usr/lib64/ccache/c++ -DUSE_ROBIN_HOOD_HASHING -DVK_ENABLE_BETA_EXTENSIONS -DVK_USE_PLATFORM_WAYLAND_KHR -DVK_USE_PLATFORM_XCB_KHR -DVK_USE_PLATFORM_XLIB_KHR -DVK_USE_PLATFORM_XLIB_XRANDR_EXT -DVkLayer_khronos_validation_EXPORTS -DXXH_NO_LONG_LONG -I/home/zmike/src/Vulkan-ValidationLayers/layers/. -isystem /home/zmike/src/Vulkan-ValidationLayers/layers/external -isystem /home/zmike/src/Vulkan-ValidationLayers/external/Debug/robin-hood-hashing/build/install/include -isystem /home/zmike/src/Vulkan-ValidationLayers/external/Debug/SPIRV-Headers/build/install/include -isystem /home/zmike/src/Vulkan-ValidationLayers/external/Debug/SPIRV-Tools/build/install/include -isystem /home/zmike/src/Vulkan-ValidationLayers/external/Debug/Vulkan-Headers/build/install/include -O3 -DNDEBUG -std=c++17 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -Wall -Wextra -Wpointer-arith -Wno-unused-parameter -MD -MT layers/CMakeFiles/VkLayer_khronos_validation.dir/stateless/buffer_sl_validation.cpp.o -MF layers/CMakeFiles/VkLayer_khronos_validation.dir/stateless/buffer_sl_validation.cpp.o.d -o layers/CMakeFiles/VkLayer_khronos_validation.dir/stateless/buffer_sl_validation.cpp.o -c /home/zmike/src/Vulkan-ValidationLayers/layers/stateless/buffer_sl_validation.cpp
In file included from /home/zmike/src/Vulkan-ValidationLayers/layers/./stateless/stateless_validation.h:21,
                 from /home/zmike/src/Vulkan-ValidationLayers/layers/stateless/buffer_sl_validation.cpp:19:
/home/zmike/src/Vulkan-ValidationLayers/layers/./stateless/parameter_name.h: In member function ‘bool ParameterName::IsValid()’:
/home/zmike/src/Vulkan-ValidationLayers/layers/./stateless/parameter_name.h:110:9: error: ‘uint32_t’ was not declared in this scope
  110 |         uint32_t count = 0;
      |         ^~~~~~~~
/home/zmike/src/Vulkan-ValidationLayers/layers/./stateless/parameter_name.h:25:1: note: ‘uint32_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’?
   24 | #include <cstring>
  +++ |+#include <cstdint>
   25 | 
/home/zmike/src/Vulkan-ValidationLayers/layers/./stateless/parameter_name.h:117:15: error: ‘count’ was not declared in this scope
  117 |             ++count;
      |               ^~~~~
/home/zmike/src/Vulkan-ValidationLayers/layers/./stateless/parameter_name.h:121:17: error: ‘count’ was not declared in this scope
  121 |         return (count == num_indices_);
      |                 ^~~~~
[18/86] Building CXX object layers/CMakeFiles/VkLayer_khronos_validation.dir/stateless/cmd_buffer_sl_validation.cpp.o
FAILED: layers/CMakeFiles/VkLayer_khronos_validation.dir/stateless/cmd_buffer_sl_validation.cpp.o 
/usr/lib64/ccache/c++ -DUSE_ROBIN_HOOD_HASHING -DVK_ENABLE_BETA_EXTENSIONS -DVK_USE_PLATFORM_WAYLAND_KHR -DVK_USE_PLATFORM_XCB_KHR -DVK_USE_PLATFORM_XLIB_KHR -DVK_USE_PLATFORM_XLIB_XRANDR_EXT -DVkLayer_khronos_validation_EXPORTS -DXXH_NO_LONG_LONG -I/home/zmike/src/Vulkan-ValidationLayers/layers/. -isystem /home/zmike/src/Vulkan-ValidationLayers/layers/external -isystem /home/zmike/src/Vulkan-ValidationLayers/external/Debug/robin-hood-hashing/build/install/include -isystem /home/zmike/src/Vulkan-ValidationLayers/external/Debug/SPIRV-Headers/build/install/include -isystem /home/zmike/src/Vulkan-ValidationLayers/external/Debug/SPIRV-Tools/build/install/include -isystem /home/zmike/src/Vulkan-ValidationLayers/external/Debug/Vulkan-Headers/build/install/include -O3 -DNDEBUG -std=c++17 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -Wall -Wextra -Wpointer-arith -Wno-unused-parameter -MD -MT layers/CMakeFiles/VkLayer_khronos_validation.dir/stateless/cmd_buffer_sl_validation.cpp.o -MF layers/CMakeFiles/VkLayer_khronos_validation.dir/stateless/cmd_buffer_sl_validation.cpp.o.d -o layers/CMakeFiles/VkLayer_khronos_validation.dir/stateless/cmd_buffer_sl_validation.cpp.o -c /home/zmike/src/Vulkan-ValidationLayers/layers/stateless/cmd_buffer_sl_validation.cpp
In file included from /home/zmike/src/Vulkan-ValidationLayers/layers/./stateless/stateless_validation.h:21,
                 from /home/zmike/src/Vulkan-ValidationLayers/layers/stateless/cmd_buffer_sl_validation.cpp:19:
/home/zmike/src/Vulkan-ValidationLayers/layers/./stateless/parameter_name.h: In member function ‘bool ParameterName::IsValid()’:
/home/zmike/src/Vulkan-ValidationLayers/layers/./stateless/parameter_name.h:110:9: error: ‘uint32_t’ was not declared in this scope
  110 |         uint32_t count = 0;
      |         ^~~~~~~~
/home/zmike/src/Vulkan-ValidationLayers/layers/./stateless/parameter_name.h:25:1: note: ‘uint32_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’?
   24 | #include <cstring>
  +++ |+#include <cstdint>
   25 | 
/home/zmike/src/Vulkan-ValidationLayers/layers/./stateless/parameter_name.h:117:15: error: ‘count’ was not declared in this scope
  117 |             ++count;
      |               ^~~~~
/home/zmike/src/Vulkan-ValidationLayers/layers/./stateless/parameter_name.h:121:17: error: ‘count’ was not declared in this scope
  121 |         return (count == num_indices_);
      |                 ^~~~~

[juan-lunarg]

Looks like part of this has been fixed by VMA upstream (GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator@383f06b)

Based on the comment in that commit we would need to test with GCC13 to catch this?