Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gltf Extensions should be split into 1.0 and 2.0 folders in the repo #1208

Closed
chipweinberger opened this issue Jan 11, 2018 · 7 comments
Closed

Comments

@chipweinberger
Copy link

I just spent 10 minutes trying to figure out why KHR_materials_common seemed so 'off', only to later realize its only for 1.0. This should be reflected in the folder structure.

Extensions/1.0/Khronos/KHR_materials_common

@Kupoman
Copy link
Contributor

Kupoman commented Jan 11, 2018

What about extensions that are compatible with multiple versions of glTF. Would they be duplicated across folders?

@chipweinberger
Copy link
Author

chipweinberger commented Jan 11, 2018

That's best and most clear, yes. 1.0 is basically dead. It's there for legacy and should not be worked on or updated anymore. So we should copy whatever extensions support 1.0 right now into the 1.0 folder, and forget about them. As a once time exception, if the extension supports both put it in both. But going forward extension spec changes intended for gltf 1.0 should probably be prohibited. Any new extensions or updates to extensions should only be allowed in the 2.0 folder.

As for another more important edge case, take KHR_material_common. A 2.0 version is being worked on for gltf 2.0, but there will still be the 1.0 version that has some amount of use use.

Thanks for the comment, that was a good question.

@donmccurdy
Copy link
Contributor

+1 for splitting extensions into 1.0 and 2.0 folders.

When we moved from glTF 1.0 to 2.0 the extensions did not "roll up", and we've been gradually defining the 2.0 versions. I'm assuming that for any glTF 2.X releases, the 2.0 extensions remain valid? Not sure if there's a precedent on this yet, but that would be my vote.

@pjcozzi
Copy link
Member

pjcozzi commented Jan 17, 2018

I agree with @donmccurdy on both points. Will run it by the Khronos working group tomorrow.

@pjcozzi
Copy link
Member

pjcozzi commented Jan 17, 2018

Also, thanks for bringing this up @chipweinberger!

@donmccurdy
Copy link
Contributor

Here's a PR: #1214

About whether extensions "roll up" with 2.X releases, it is our current expectation that the 2.0 extensions remain valid, but this could depend on details of the (hypothetical) 2.X change and extensions involved.

@pjcozzi
Copy link
Member

pjcozzi commented Jan 24, 2018

@chipweinberger thanks for bring this up. #1214 was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants