Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling illuminance "intensity" is worth avoiding #2135

Closed
erich666 opened this issue Mar 23, 2022 · 3 comments
Closed

Calling illuminance "intensity" is worth avoiding #2135

erich666 opened this issue Mar 23, 2022 · 3 comments

Comments

@erich666
Copy link

erich666 commented Mar 23, 2022

I've been looking at various apps and how they specify physical lights in their user interface. It's a minor point, but I hope you can avoid using "intensity" as the name for the parameter. Something neutral like "scale," "multiplier," or "brightness" would be better, I believe. Or store "illuminance" separately, though that could be confusing and I dislike it. We've kind of run out of words for describing lights in English, but "intensity" implies "luminous intensity," measured in candelas. Which of course makes little sense for directional lights like the sun, where your proposal properly uses illuminance, in lux.

Like I say, a minor point, but "intensity" is misused by so many apps that it'd be nice to avoid the term or use it properly. I've seen "intensity" as sometimes non-physical and unitless (like in FBX, Unreal Editor, and Unity), it's sometimes used for "intensity and exposure" (a camera-centric description used in Arnold and Houdini, among others), and sometimes misused entirely. This confusion gets propagated by web pages like this one, which says "Lux is a standardized unit of measurement of the light intensity" when earlier they correctly said that a candela was "The SI base unit of luminous intensity." Please don't add to the confusion.

gets off soapbox

@pjcozzi
Copy link
Member

pjcozzi commented Mar 24, 2022

@erich666 thanks for the vocab insights!

@McNopper any thoughts on this given KHR_lights_punctual?

@UX3D-nopper
Copy link
Contributor

At first, we can't change the parameter anymore. This would break the compatibility.
However, we could bettere clarify - for the end user and the coder - what this intensity means. The current wording is like this:

Brightness of light in. The units that this is defined in depend on the type of light. point and spot lights use luminous intensity in candela (lm/sr) while directional lights use illuminance in lux (lm/m2)

@erich666 Maybe you can fork and make a pull request where aditional notes are explaining your concerns in a positive way. Please cross check with @lexaknyazev if this is possible at all.

@erich666
Copy link
Author

erich666 commented Mar 25, 2022

Thanks for the fast response. I understand it's too late to change the name. I'll see if I can think of some way to improve the docs. But, TBH, probably won't - it already clearly states "intensity" is luminous intensity for local light sources, actually illuminance in lux for those at infinity (the right choices). People will cope. It's already a crazy world to try to combine full sunlight (100k lux) with local lights (more in the 100 candelas range) - people tend to fudge (I do!) if both are in a scene, e.g., an interior with sun coming in the window and if there's no global illumination rendering to bounce light around and no tone mapping. Me, I'm happy to see you add physical lighting units in any form, so, thanks! You're ahead of USD in this regard (I'm indirectly pushing on them, too).

FWIW, Wikipedia notes the same problem with the word "intensity" for radiometric unit descriptions, e.g., "Irradiance is often called intensity, but this term is avoided in radiometry where such usage leads to confusion with radiant intensity." Their page about illuminance shows less frustration in this area :).

Anyway, I've said my piece, sounds like it's locked in stone, so I'll close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants