Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update KHR_materials_extension to newest draft #523

Closed
tfili opened this issue Jan 11, 2016 · 7 comments
Closed

Update KHR_materials_extension to newest draft #523

tfili opened this issue Jan 11, 2016 · 7 comments

Comments

@tfili
Copy link

tfili commented Jan 11, 2016

I believe the only change that is needed is removing type from the material values.

For example, this

"values": {
    "diffuse": {
        type: 35666,
        value: [0.5, 0.5, 0.5, 1]
    }
}

should be changed to this

"values": {
    "diffuse": [0.5, 0.5, 0.5, 1]
}
@tparisi
Copy link
Contributor

tparisi commented Jan 12, 2016

are we removing type ? It's in the sample models...

@pjcozzi
Copy link
Member

pjcozzi commented Jan 12, 2016

Yes, we plan to update the sample models by the end of the month: CesiumGS/cesium#3413 (comment)

@tparisi
Copy link
Contributor

tparisi commented Jan 13, 2016

@pjcozzi OK then we'll need to update all loaders, too. e.g. Three.js. Please let me know when you update the samples and I'll do the loader.

@pjcozzi
Copy link
Member

pjcozzi commented Jan 13, 2016

Will do. End of the month, latest.

@pjcozzi
Copy link
Member

pjcozzi commented Feb 3, 2016

@tparisi here are the updated sample models courtesy of @tfili - #531

@pjcozzi
Copy link
Member

pjcozzi commented Jul 16, 2017

@McNopper OK to close as duplicate with #947 and #945?

@UX3D-nopper
Copy link
Contributor

Yes, as it is not valid anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants